Skip to content

[IMP] l10n_sa_{edi}: allow backdating invoices - #237191

Closed
fw-bot wants to merge 1 commit into
odoo:saas-18.4from
odoo-dev:saas-18.4-17.0-l10n_sa_edi-flexible-issue-date-khom-479238-fw
Closed

[IMP] l10n_sa_{edi}: allow backdating invoices#237191
fw-bot wants to merge 1 commit into
odoo:saas-18.4from
odoo-dev:saas-18.4-17.0-l10n_sa_edi-flexible-issue-date-khom-479238-fw

Conversation

@fw-bot

@fw-bot fw-bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Previously, l10n_sa_confirmation_datetime represented the time where the invoice was posted,
that meant that we could not backdate invoices, since it would cause disparity between
what zatca receives and what we consider in odoo (i.e. invoice_date)

This commit allows us to set the date component of l10n_sa_confirmation_datetime to the
invoice_date so we can safely backdate invoices.

task-5009969


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #236979
Forward-Port-Of: #229517

@robodoo

robodoo commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@fw-bot

fw-bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@khom-odoo @gawa-odoo cherrypicking of pull request #229517 failed.

stdout:

Auto-merging addons/l10n_sa/__manifest__.py
Auto-merging addons/l10n_sa/i18n/l10n_sa.pot
CONFLICT (content): Merge conflict in addons/l10n_sa/i18n/l10n_sa.pot
Auto-merging addons/l10n_sa/models/account_move.py
CONFLICT (content): Merge conflict in addons/l10n_sa/models/account_move.py
Auto-merging addons/l10n_sa/views/account_move_views.xml
CONFLICT (add/add): Merge conflict in addons/l10n_sa/views/account_move_views.xml

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Nov 24, 2025
Previously, `l10n_sa_confirmation_datetime` represented the time where the invoice was posted,
that meant that we could not backdate invoices, since it would cause disparity between
what zatca receives and what we consider in odoo (i.e. `invoice_date`)

This commit allows us to set the date component of `l10n_sa_confirmation_datetime` to the
`invoice_date` so we can safely backdate invoices.

task-5009969

X-original-commit: 8890418
@khom-odoo
khom-odoo force-pushed the saas-18.4-17.0-l10n_sa_edi-flexible-issue-date-khom-479238-fw branch from 832cf84 to 292e204 Compare November 25, 2025 07:18
@khom-odoo

Copy link
Copy Markdown
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 25, 2025
Previously, `l10n_sa_confirmation_datetime` represented the time where the invoice was posted,
that meant that we could not backdate invoices, since it would cause disparity between
what zatca receives and what we consider in odoo (i.e. `invoice_date`)

This commit allows us to set the date component of `l10n_sa_confirmation_datetime` to the
`invoice_date` so we can safely backdate invoices.

task-5009969

closes #237191

X-original-commit: 8890418
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Signed-off-by: Omar Khalid (khom) <khom@odoo.com>
@robodoo robodoo closed this Nov 25, 2025
@fw-bot
fw-bot deleted the saas-18.4-17.0-l10n_sa_edi-flexible-issue-date-khom-479238-fw branch December 2, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants