[FIX] stock: assign SN on move Lines by svs-odoo · Pull Request #41284 · odoo/odoo

svs-odoo · 2019-12-03T16:23:46Z

Before this commit, we can't use the Generate and Assign Serial Numbers on already existing move line. It always creates new one, even if the picking type use "Pre-fill Detailed Operations".
Now, it will edit existing lines, except if we ask to generate more SN than we have unassigned move lines, or if the picking don't use the "Pre-fill Detailed Operations" option, in which cases it will still create new move line with the generated SN.

task-2150561

sle-odoo · 2019-12-16T13:54:37Z

not sure it's more concise than typing this whole filer two times

Indeed it's longer, but I find this:

if self.picking_type_id.show_reserved: move_lines = self.move_line_ids.filtered(without_lot_filter) else: move_lines = self.move_line_nosuggest_ids.filtered(without_lot_filter)

... is clearer than that:

if self.picking_type_id.show_reserved: move_lines = self.move_line_ids.filtered(lambda ml: not ml.lot_id and not ml.lot_name) else: move_lines = self.move_line_nosuggest_ids.filtered(lambda ml: not ml.lot_id and not ml.lot_name)

But we can use the lambda one, I don't mind.

sle-odoo · 2019-12-16T13:58:02Z

do you really need origin_move_line?

Before this commit, we can't use the Generate and Assign Serial Numbers on already existing move line. It always creates new one, even if the picking type use "Pre-fill Detailed Operations". Now, it will edit existing lines, except if we ask to generate more SN than we have unassigned move lines, or if the picking don't use the "Pre-fill Detailed Operations" option, in which cases it will still create new move line with the generated SN. Also, before this commit, paste a list of serial numbers to assign them on multiple move lines in once work only with creation of a new move line for each serial number. Now, it's also work with existing move lines. Finally, some code shared the same logic in `stock.move` in the move line onchange method and in the `_generate_serial_numbers` method. Moves this code in a new method, `_generate_serial_move_line_commands`, and call it in the two previous methods. task-2150561

The onchange on move lines will generates and assigns lot names. However it's useless to do that if the picking type doesn't allow creation of new lots.

sle-odoo · 2019-12-23T14:57:42Z

robodoo r+ rebase-ff

robodoo · 2019-12-23T14:58:10Z

Merge method set to rebase and fast-forward

robodoo added the seen 🙂 label Dec 3, 2019

C3POdoo added the RD research & development, internal work label Dec 3, 2019

robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 3, 2019

svs-odoo force-pushed the 13.0-fix-assign-sn-on-move-line-svs branch from 3299476 to 1bf703c Compare December 4, 2019 09:48

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Dec 4, 2019

svs-odoo force-pushed the 13.0-fix-assign-sn-on-move-line-svs branch from 06fb3c2 to 76440e2 Compare December 4, 2019 13:47

robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 4, 2019

amoyaux reviewed Dec 12, 2019

View reviewed changes