[FW][FIX] website: fix tabs breaking when increasing number of columns - #42130
Closed
fw-bot wants to merge 1 commit into
Closed
Conversation
* web_editor Previously, increasing the number of columns on the tabs snippet would cause the newly created tabs to toggle the original tabs instead of its own, this was caused by an oversight where the columns were clone directly using jQuery, and the snippets' the onClone method was not called on the newly created columns (here, tabs). This commit move the responsibility to clone onto the SnippetsMenu so that it can create the appropriate snippetEditor if needed and call its onClone method. task-2070643 X-original-commit: 77ebadf
Contributor
Author
|
Ping @sdegueldre, @qsm-odoo To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 18, 2019
* web_editor Previously, increasing the number of columns on the tabs snippet would cause the newly created tabs to toggle the original tabs instead of its own, this was caused by an oversight where the columns were clone directly using jQuery, and the snippets' the onClone method was not called on the newly created columns (here, tabs). This commit move the responsibility to clone onto the SnippetsMenu so that it can create the appropriate snippetEditor if needed and call its onClone method. task-2070643 closes #42130 X-original-commit: 77ebadf Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
qsm-odoo
deleted the
master-12.0-website-tabs-break-when-increasing-columns-sad-GKAb-fw
branch
December 19, 2019 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, increasing the number of columns on the tabs snippet would
cause the newly created tabs to toggle the original tabs instead of its
own, this was caused by an oversight where the onClone method was not
called on the newly created tab. This commit fixes that issue.
task-ID: 2070643
Forward-Port-Of: #42109
Forward-Port-Of: #41125