[FW][FIX] web: reload search panel before view model - #54040
Closed
fw-bot wants to merge 2 commits into
Closed
Conversation
Problem: Go to the application apps, select accounting in the search panel, then filter on lunch in the search bar: the category all is displayed as selected in the search panel (accounting is no more a valid value since expand="0") but the application lunch does not appear in the kanban view. Root cause: The kanban model is reloaded with the old domain using accounting without waiting the search panel to be reloaded but it is only known after the search panel has been reloaded that the accounting value is no more valid and that all should be selected instead of accounting, thus that the domain used by the kanban model should be updated. Solution: The solution to the problem is simple: first reload the search panel, then reload the view model with the updated domain. X-original-commit: 8589bab
In the search panel, the categories, i.e. fields select="one", with attributes expand="0", and enable_counters="0" (defaults) were not correctly updated when the domain outside of the search panel was updated. This is no longer the case. X-original-commit: 99e9cac
Contributor
Author
|
Ping @Polymorphe57, @aab-odoo To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@fw-bot r+ |
Contributor
|
Linked pull request(s) odoo/enterprise#11642 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Jul 3, 2020
In the search panel, the categories, i.e. fields select="one", with attributes expand="0", and enable_counters="0" (defaults) were not correctly updated when the domain outside of the search panel was updated. This is no longer the case. closes #54040 X-original-commit: 99e9cac Related: odoo/enterprise#11642 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-Port-Of: #53970