Skip to content

[FW][FIX] sale_account_taxcloud: add tax on options (portal) - #56110

Closed
fw-bot wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-12.0-opw-2310614-refix-sig-AGLd-fw
Closed

[FW][FIX] sale_account_taxcloud: add tax on options (portal)#56110
fw-bot wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-12.0-opw-2310614-refix-sig-AGLd-fw

Conversation

@fw-bot

@fw-bot fw-bot commented Aug 19, 2020

Copy link
Copy Markdown
Contributor

Steps to reproduce

Enable optional products in sale order
Make a sale order with optional products for a portal customer
with taxcloud fiscal position. Validate the order.
Tax will be calculated on the sol.

Access the sale order as the portal user.
Add the optional product, verify the order and pay.

The optional product will get the taxcloud data
AFTER the order has been verified and possibly paid. As this should not
occur this add the override to calculate taxcloud data right after
adding the optional product

opw-2310614

Co-authored-by: agr-odoo agr@odoo.com

Forward-Port-Of: #56083
Forward-Port-Of: #56037

@robodoo robodoo added forwardport This PR was created by @fw-bot seen 🙂 labels Aug 19, 2020
@fw-bot

fw-bot commented Aug 19, 2020

Copy link
Copy Markdown
Contributor Author

Ping @simongoffin
This PR targets master and is the last of the forward-port chain containing:

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot

fw-bot commented Aug 19, 2020

Copy link
Copy Markdown
Contributor Author

Ping @simongoffin

ci/upgrade_odoo failed on this forward-port PR

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Aug 19, 2020
@simongoffin

Copy link
Copy Markdown
Contributor

Hello @d-fence

Peux tu m'éclairer je ne comprends pas le problème?
Cette PR est liée à celle là en enterprise https://github.com/odoo/enterprise/pull/12510

@d-fence

d-fence commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

You have to rebase, the odoo branch seems out of sync (see the warning on the batch page)
The mentioned fields were removed in between time (see in upgrade master branch if you want more infos).

@simongoffin

Copy link
Copy Markdown
Contributor

@fw-bot r+

@fw-bot

fw-bot commented Aug 24, 2020

Copy link
Copy Markdown
Contributor Author

This PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

Steps to reproduce

Enable optional products in sale order
Make a sale order with optional products for a portal customer
with taxcloud fiscal position. Validate the order.
Tax will be calculated on the sol.

Access the sale order as the portal user.
Add the optional product, verify the order and pay.

The optional product will get the taxcloud data
AFTER the order has been verified and possibly paid. As this should not
occur this add the override to calculate taxcloud data right after
adding the optional product

opw-2310614

X-original-commit: a7a91d5
Co-authored-by: agr-odoo <agr@odoo.com>
@simongoffin

Copy link
Copy Markdown
Contributor

@fw-bot r+

@robodoo robodoo added ☑ ci/upgrade_odoo CI 🤖 Robodoo has seen passing statuses and removed ☐ ci/runbot labels Aug 24, 2020
@simongoffin

Copy link
Copy Markdown
Contributor

robodoo r+

1 similar comment
@simongoffin

Copy link
Copy Markdown
Contributor

robodoo r+

@robodoo

robodoo commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

I'm sorry, @simongoffin. This PR is already reviewed, reviewing it again is useless.

robodoo pushed a commit that referenced this pull request Aug 25, 2020
Steps to reproduce

Enable optional products in sale order
Make a sale order with optional products for a portal customer
with taxcloud fiscal position. Validate the order.
Tax will be calculated on the sol.

Access the sale order as the portal user.
Add the optional product, verify the order and pay.

The optional product will get the taxcloud data
AFTER the order has been verified and possibly paid. As this should not
occur this add the override to calculate taxcloud data right after
adding the optional product

opw-2310614

closes #56110

X-original-commit: a7a91d5
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: agr-odoo <agr@odoo.com>
@robodoo robodoo closed this Aug 25, 2020
@robodoo
robodoo temporarily deployed to merge August 25, 2020 13:45 Inactive
@simongoffin
simongoffin deleted the master-12.0-opw-2310614-refix-sig-AGLd-fw branch August 25, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI 🤖 Robodoo has seen passing statuses forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants