Skip to content

[IMP] (account, payment): payment method improvements - #72104

Closed
vin-odoo wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-payment-payment-method-improvement-vin
Closed

[IMP] (account, payment): payment method improvements#72104
vin-odoo wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-payment-payment-method-improvement-vin

Conversation

@vin-odoo

@vin-odoo vin-odoo commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

To improve the payment method system, proceed to a few changes
such as adding a setup button to directly open the acquirer form from the
journal, and changing the style of lines linked to a disabled acquirer.

Task id #2573145

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@vin-odoo
vin-odoo requested a review from a team as a code owner June 14, 2021 08:08
@robodoo

robodoo commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Jun 14, 2021
@AntoineVDV

Copy link
Copy Markdown
Contributor

Hello @vin-odoo, is there a task to follow? If so, could you reference it in the commit message? Thanks!

@vin-odoo

Copy link
Copy Markdown
Contributor Author

Hi @AntoineVDV, these changes are based on feedback given to me directly by @tsb-odoo and AVW.
As far as I know, there is not task for them.

@tsb-odoo

Copy link
Copy Markdown
Contributor

Hi @AntoineVDV, let me know if the absence of task is a blocking point.
cc : @vin-odoo

@AntoineVDV

AntoineVDV commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

@tsb-odoo @vin-odoo This is not blocking but it would still be a good idea to create one, even after the dev is done. To have an entry in the release notes is already a good reason on its own. Allowing RD India to test the branch is another. One might also need to understand and discuss this change in a few months/years.

@AntoineVDV AntoineVDV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a few review comments below :)

Also, your commit title should start with "[IMP] payment" rather than "[IMP] account" since this is the module that is modified.

Comment thread addons/payment/__manifest__.py Outdated
Comment thread addons/payment/models/account_payment_method.py Outdated
Comment thread addons/payment/models/account_payment_method.py Outdated
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch from f26cc3e to c4a9983 Compare June 14, 2021 14:03
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch 4 times, most recently from 38eff1b to 3551a5f Compare June 28, 2021 08:11
@vin-odoo
vin-odoo requested review from a team as code owners June 28, 2021 08:11
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch from 3551a5f to dec3418 Compare June 28, 2021 08:15
@vin-odoo
vin-odoo marked this pull request as draft June 28, 2021 08:21
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch 8 times, most recently from 215208c to 035dc27 Compare July 2, 2021 07:43
@C3POdoo
C3POdoo requested a review from a team July 2, 2021 07:45
@AntoineVDV
AntoineVDV removed the request for review from a team July 2, 2021 07:52
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch from 035dc27 to 48a6ece Compare July 2, 2021 08:27
@vin-odoo vin-odoo changed the title [IMP] account: payment method improvements [IMP] (account, payment): payment method improvements Jul 2, 2021
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch 8 times, most recently from 8c0baba to cf61ee3 Compare July 8, 2021 06:57
Various improvements to the payment method system,
in order to make it better and more robust.

Task id #2573145
@vin-odoo
vin-odoo force-pushed the master-payment-payment-method-improvement-vin branch from cf61ee3 to 51eda59 Compare July 8, 2021 07:26
@vin-odoo

vin-odoo commented Jul 8, 2021

Copy link
Copy Markdown
Contributor Author

It was decided that these fixes were really important and thus should be done in 14.4

@vin-odoo vin-odoo closed this Jul 8, 2021
@xmo-odoo
xmo-odoo deleted the master-payment-payment-method-improvement-vin branch March 7, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants