Skip to content

[FW][FIX] digest: avoid exception on user creation - #73237

Closed
fw-bot wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-12.0-fix_missing_digest_user_invite-pmo-Y4DF-fw
Closed

[FW][FIX] digest: avoid exception on user creation#73237
fw-bot wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-12.0-fix_missing_digest_user_invite-pmo-Y4DF-fw

Conversation

@fw-bot

@fw-bot fw-bot commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

Scenario to reproduce the issue on runbot 12.0 Community:

  • Go to Settings > Technical > Email > Digest Emails
  • Select the Weekly Digest
  • Click on Action > Delete
  • Click on OK
  • Go to Settings > Users & Companies > Users
  • Click on Create
  • Fill the Name and the Email Address
  • Save
  • Odoo Server Error - Missing Record

Some users seem to delete this record to stop receiving the digest for everyone, including for future users. The problem is that, even if the digest has been deleted, the config parameters are still referencing it.

This commit prevents the exception by having an empty recordset if the digest does not exist.

Forward-Port-Of: #73165
Forward-Port-Of: #73077

Scenario to reproduce the issue on runbot 12.0 Community:
- Go to Settings > Technical > Email > Digest Emails
- Select the Weekly Digest
- Click on Action > Delete
- Click on OK
- Go to Settings > Users & Companies > Users
- Click on Create
- Fill the Name and the Email Address
- Save
- Odoo Server Error - Missing Record

Some users seem to delete this record to stop receiving the digest for
everyone, including for future users.  The problem is that, even if the
digest has been deleted, the config parameters are still referencing it.

This commit prevents the exception by having an empty recordset if the
digest does not exist.

X-original-commit: 2910bd2
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Jul 5, 2021
@robodoo

robodoo commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@fw-bot

fw-bot commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

Ping @madprog
This PR targets master and is the last of the forward-port chain containing:

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Jul 5, 2021
@madprog

madprog commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Jul 6, 2021
Scenario to reproduce the issue on runbot 12.0 Community:
- Go to Settings > Technical > Email > Digest Emails
- Select the Weekly Digest
- Click on Action > Delete
- Click on OK
- Go to Settings > Users & Companies > Users
- Click on Create
- Fill the Name and the Email Address
- Save
- Odoo Server Error - Missing Record

Some users seem to delete this record to stop receiving the digest for
everyone, including for future users.  The problem is that, even if the
digest has been deleted, the config parameters are still referencing it.

This commit prevents the exception by having an empty recordset if the
digest does not exist.

closes #73237

X-original-commit: 2910bd2
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>
@robodoo robodoo added the 14.5 label Jul 6, 2021
@robodoo robodoo closed this Jul 6, 2021
@robodoo
robodoo temporarily deployed to merge July 6, 2021 08:38 Inactive
@madprog
madprog deleted the master-12.0-fix_missing_digest_user_invite-pmo-Y4DF-fw branch July 6, 2021 08:39
@xmo-odoo xmo-odoo added 15.0 and removed 14.5 labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15.0 forwardport This PR was created by @fw-bot RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants