Generate CLI parity matrix from help output#2134
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | --version | -V | --version | general | off | implemented | Available in oc-rsync CLI help output. | | ||
| | --help | -h (*) | --help | general | off | implemented | Available in oc-rsync CLI help output. | | ||
| | --connect-program=COMMAND | | --connect-program=COMMAND | oc-rsync-only | n/a | divergent | Present in oc-rsync CLI but not listed in upstream rsync --help output. | | ||
| | --remote-option=OPTION | -M | --remote-option=OPTION | oc-rsync-only | n/a | divergent | Present in oc-rsync CLI but not listed in upstream rsync --help output. | |
There was a problem hiding this comment.
The row for --remote-option=OPTION (line 157) claims this flag is “oc-rsync-only”, yet the same file already lists --remote-option=OPT as implemented (line 135) and rsync --help in this repo (rsync --help | rg -- '--remote-option') clearly exposes the option. The generator compared the entire help string (including the argument placeholder) rather than the option name, so any cosmetic difference (OPT vs OPTION, RATE vs RATE[:BURST], FMT vs FORMAT, etc.) creates duplicate entries that simultaneously mark the upstream option as “missing” while adding a divergent oc-only version (see also lines 142↔167 and 138↔183, and the corresponding entries in docs/parity-options.yml). This contradicts the actual CLIs and corrupts the machine-readable dataset automation relies on. Please normalize the option tokens before comparing the two help outputs so shared options aren’t misclassified.
Useful? React with 👍 / 👎.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…ases (#2134) (#4208) Survey the six state machines in the protocol and daemon negotiation paths (SessionState, DynamicProtocolState, ProtocolState<P>, NegotiationPipeline<S>, setup_protocol, handle_legacy_session) with file:line citations, sketch a DaemonConnection<S> shape for the legacy handshake, and recommend selective adoption: type-state the daemon connection lifecycle and the setup_protocol negotiation prologue, keep the runtime enums as registry/observability mirrors, and reject for the multi-thread transfer phase.
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…ases (#2134) (#4208) Survey the six state machines in the protocol and daemon negotiation paths (SessionState, DynamicProtocolState, ProtocolState<P>, NegotiationPipeline<S>, setup_protocol, handle_legacy_session) with file:line citations, sketch a DaemonConnection<S> shape for the legacy handshake, and recommend selective adoption: type-state the daemon connection lifecycle and the setup_protocol negotiation prologue, keep the runtime enums as registry/observability mirrors, and reject for the multi-thread transfer phase.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…ases (#2134) (#4208) Survey the six state machines in the protocol and daemon negotiation paths (SessionState, DynamicProtocolState, ProtocolState<P>, NegotiationPipeline<S>, setup_protocol, handle_legacy_session) with file:line citations, sketch a DaemonConnection<S> shape for the legacy handshake, and recommend selective adoption: type-state the daemon connection lifecycle and the setup_protocol negotiation prologue, keep the runtime enums as registry/observability mirrors, and reject for the multi-thread transfer phase.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsync --helpvsoc-rsync --helpparity-options.ymlso tooling shares the same status datasetTesting
Codex Task