docs(design): spawn_blocking bridge for rayon work in async daemon (#1751)#4196
Merged
Merged
Conversation
…1751) Document the canonical sync/async bridge between rayon-dispatched CPU work and the tokio runtime that will host the async daemon listener landing in #1935. Inventories 30 rayon call sites reachable from the daemon code paths, fixes the bridge signature, sizing recipe for both pools, anti-patterns to forbid in review, migration order keyed to phase 2 of the async migration plan, and a test strategy that does not require the async daemon to exist yet.
github-actions
Bot
added
the
documentation
3 tasks
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
3 tasks
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1751) (#4196) Document the canonical sync/async bridge between rayon-dispatched CPU work and the tokio runtime that will host the async daemon listener landing in #1935. Inventories 30 rayon call sites reachable from the daemon code paths, fixes the bridge signature, sizing recipe for both pools, anti-patterns to forbid in review, migration order keyed to phase 2 of the async migration plan, and a test strategy that does not require the async daemon to exist yet.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…1751) (#4196) Document the canonical sync/async bridge between rayon-dispatched CPU work and the tokio runtime that will host the async daemon listener landing in #1935. Inventories 30 rayon call sites reachable from the daemon code paths, fixes the bridge signature, sizing recipe for both pools, anti-patterns to forbid in review, migration order keyed to phase 2 of the async migration plan, and a test strategy that does not require the async daemon to exist yet.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/design/spawn-blocking-bridge.mdcovering the canonical sync/async bridge between rayon-dispatched CPU work and the tokio runtime that will host the async daemon listener landing in Normalize quoted fallback keywords #1935.rayon_bridgehelper signature, sizing recipe for the rayon pool and tokio blocking pool, anti-patterns to forbid at review, migration order keyed to phase 2 ofasync-migration-plan.md, and a test strategy that does not require the async daemon to exist yet.Pure docs change. No code. The async daemon does not exist yet so the bridge cannot be implemented in this PR. Tracking: #1751, companion to #1935 (impl), #1367 (eval), #1594 (plan).
Test plan