Add parity test for sparse with preallocate#2136
Merged
Merged
Conversation
3 tasks
4 tasks
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 16, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
This was referenced May 17, 2026
oferchen
added a commit
that referenced
this pull request
May 17, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
oferchen
added a commit
that referenced
this pull request
May 18, 2026
Expand the placeholder async migration plan into a comprehensive, opinionated design covering: current synchronous threading model per subsystem, per-subsystem cost/benefit, a phased incremental adoption strategy, tokio runtime choice with rejected alternatives, sync/async bridge patterns, backward-compat strategy, risk register, and open questions. Cross-references existing async-related tasks (#1367, #1411, #1591, #1593, #1595, #1674, #1751, #1779, #1780, #1782, #1796, #1797, #1805, #1806, #1889, #1890, #1891, #1892, #1934, #1935, #2136) and related design notes so future planners have a single anchor.
oferchen
added a commit
that referenced
this pull request
May 18, 2026
…2136) (#4210) Reframe the actor-pattern evaluation around supervised tokio tasks (Erlang/Akka style with bounded mailboxes and a supervisor that restarts crashed actors) to match the post-async-migration target the migration plan commits us to. The recommendation stays: reject the actor reshape for the production hot path because rsync's wire protocol is sequential with no resume primitive, so supervisor restart is a no-op; adopt the actor surface only for multi-host fan-out and fault-injection tests, behind --features async-pipeline. Cross-references #4186 (async migration plan), #4196 (spawn_blocking bridge), #2134 (type-state for protocol phases, recently merged), and #1935 (async daemon listener).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sparsetogether with--preallocateTesting
Codex Task