Don't use a shared closure for each spawned thread - #27
Open
awilfox wants to merge 1 commit into
Open
Conversation
I identified a memory leak in a long-running Rails app using OkComputer and found it only triggered when `check_in_parallel` was `true`. Codex found the bug, but I authored the patch myself based on its analysis. I did not accept its initial suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I identified a memory leak in a long-running Rails app using OkComputer and found it only triggered when
check_in_parallelwastrue.Codex found the bug, but I authored the patch myself based on its analysis. I did not accept its initial suggestion.
--
Using a closure here keeps the immediate environment 'live', which means all thread objects are accessible to all other threads. This compounded a memory leak scenario in
timeoutwhich was keeping a single thread alive – in an app with 10 checks, it would leak all 10 threads instead of just the one with the timeout issue.