Skip to content

Don't use a shared closure for each spawned thread #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awilfox wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Don't use a shared closure for each spawned thread #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#### Unreleased
* Don't use a shared closure for each spawned thread
> awilfox: https://github.com/okcomputer-ruby/okcomputer/pull/27
* Add SolidQueue checks: `SolidQueueCheck` (liveness + job stats),
`SolidQueueBackedUpCheck` (per-queue backlog), `SolidQueueFailedJobsCheck`
(total failed jobs), `SolidQueueFailedJobsRateCheck` (rapid increase in
Expand Down
5 changes: 1 addition & 4 deletions lib/ok_computer/check_collection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ def check_in_sequence
end

def check_in_parallel
threads = checks.map do |check|
Thread.new { check.run }
end
threads.each(&:join)
checks.map{ |check| Thread.new(check, &:run) }.each(&:join)
end
end
end