Toolchain refresh: flake package with tested builds, gems4nix, Ruby 3.4, rubocop-clean - #15
Merged
Conversation
The README still carried bundle-gem template TODOs. Document the installed reality: presence and blank helpers, type assertions, Option and Result combinators, pattern matching, serialization refusal, and the Rails integration. Examples mirror the YARD doctests.
TDD red-green-refactor, the layered test gate ladder (rubocop and the suite per edit, nix build and flake check before push, CI green after), commit and comment conventions, and correct > simple > performant.
nix build .#errgonomic builds the gem as a derivation and runs the full rake suite (unit tests + doctests) in its checkPhase; checks reuse the packages so nix flake check certifies build and tests together. Gem management moves from bundix/gemset.nix to gems4nix, which reads Gemfile.lock directly. The lockfile is regenerated with the CHECKSUMS section and precompiled platform variants gems4nix requires. The committed gem-groups.json keeps evaluation pure (no Ruby IFD) so all four target systems evaluate from one machine; rake gems4nix:groups regenerates it. nixpkgs moves to nixos-26.05 (Ruby 3.4).
setup-ruby resolves "3.4" to its newest patch release, matching the Ruby pinned by the flake. A support matrix down to a minimum Ruby can slot into the same list later.
The keyword existed for parity with Rails' delegate but was silently ignored; the generated delegation method is now private when requested.
Fix what improves the library: doc comments on every errgonomic-owned class and module, alias over alias_method, frozen string literals, super() in Some#initialize, and the overlong gemspec line. Exempt what is deliberate, with rationale in .rubocop.yml: the capitalized Some/None/Ok/Err constructors, the full combinator surface on Option::Any and Result::Any, doctest expectation lines, and the vendored core_ext presence patches. The class-level doctest on result.rb's Object reopening moved to a comment warning: YARD keeps one docstring per object across reopenings, so examples there get silently dropped once other files document Object. Its assertions already exist on the methods themselves.
nz
force-pushed
the
chore/toolchain-refresh
branch
from
July 23, 2026 15:55
05d437d to
802b62f
Compare
h3h
approved these changes
Jul 23, 2026
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle gemtemplate TODOs.nix build .#errgonomic) whose checkPhase runs the full rake suite, andchecksreuses the packages sonix flake checkcertifies build + tests. Gem management moves from bundix/gemset.nixto gems4nix readingGemfile.lockdirectly (regenerated with CHECKSUMS + precompiled platform variants). A committedgem-groups.jsonavoids the group-inference IFD so all four systems evaluate from one machine (rake gems4nix:groupsregenerates it). nixpkgs bumped to nixos-26.05 (Ruby 3.4).delegate_optionalhonorsprivate:(was accepted for Rails-delegate parity but silently ignored) — implemented test-first.Some/Okconstructors, combinator class size, doctest lines, vendored core_ext).Test plan
bundle exec rubocop— 16 files, no offensesbundle exec rake— 4 unit runs / 8 assertions, 59 doctest runs / 147 assertions, all greennix flake check— package builds, suite passes in checkPhasenix flake check --all-systems— all four systems evaluate