README: unwrap! guidance and ActiveRecordOptional scope - #37
Merged
Conversation
Two guidance gaps: nothing said unwrap!/expect! belong in tests rather than application code, and nothing said including ActiveRecordOptional wraps every nullable column and optional association with no per-attribute opt-in. Closes #26.
nz
enabled auto-merge
August 7, 2026 18:34
lutzcc1
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
Most of the issue predates the README refresh that landed in #15: the scaffold TODOs are gone, and Option, Result, pattern matching, pedantic checks, and the Rails integrations are documented. The departures-from-Rust ask is covered by the presence paragraph (#27), the equality paragraph (#35), and the named ActiveRecord compromise set (#36).
This PR adds the two asks still missing:
unwrap!/expect!are for tests and consoles, not application code, with the reasoning (they reintroduce the ambiguous failure the type exists to prevent). The same guidance ships in Teach the combinators from method_missing #33's error message.ActiveRecordOptional: every nullable column andoptional: trueassociation is wrapped, no per-attribute opt-in.