Skip to content

Remove the Vizarr display#511

Merged
joshmoore merged 2 commits into
ome:mainfrom
lubianat:remove-the-fish
May 13, 2026
Merged

Remove the Vizarr display#511
joshmoore merged 2 commits into
ome:mainfrom
lubianat:remove-the-fish

Conversation

@lubianat
Copy link
Copy Markdown
Contributor

Reverting #483 while a robust fix for #507 is not found. It is really not great to show a broken viewer in the first part of the website (sorry for that!).

The fix on #509 is only partial; it also fails for some mobile devices (as noted in #507).

cc @lorenzocerrone

Reverting ome#483 while a robust fix for ome#507 is not found.

The fix on ome#509  is only partial; it also fails for some mobile devices (as noted in ome#507)
@github-actions
Copy link
Copy Markdown
Contributor

Automated Review URLs

@lubianat
Copy link
Copy Markdown
Contributor Author

@will-moore would you mind sharing your thoughts on this quickly?

Comment thread index.md
@will-moore
Copy link
Copy Markdown
Member

I have tried to reproduce the bug with all the options on #507 but have so far failed (Chrome Version 147.0.7727.102 on Mac). So it's tricky for me to understand where this bug is coming from.
If I change my page zoom then I sometimes see the image disappear (moves out of the viewport) but I think this is because the current viewport position (maintained in the iframe vizarr url) no-longer is suitable for the resized viewer. This is always fixed for me with a page refresh.
It's not clear to me how the bug demos on #507 would be affected by a page refresh after zooming/resizing the page? I guess the original bug report was not due to a page resize/zoom.

@jo-mueller
Copy link
Copy Markdown
Contributor

My feeling would be that while it's of course problematic that it doesn't work on mobile devices, it's kind of not that bad as long as it displays on other devices?

@lubianat
Copy link
Copy Markdown
Contributor Author

@will-moore there are two bugs detected:

  • One desktop issue with Chrome and particular Zoom levels, fixed on https://github.com/BioNGFF/vizarr. It led not only to the image disappearing, but to the canvas "twitching". I could reproduce on multiple pages embedding the hms Vizarr page.

  • One issue on a few mobile devices, which affects at least my device.

As the issue occurs also when going to Vizarr and, say, the new BIA website (ping @matthewh-ebi), I would remove the image from the main page as a hotfix while things are not solved on the Vizarr side.

@joshmoore joshmoore mentioned this pull request May 13, 2026
@joshmoore
Copy link
Copy Markdown
Member

Supportive of @lubianat's comment this morning that he won't be able to drive this. Removing for the moment, but very supportive if/when someone else wants to take on the investigation and/or assert that it's been fixed upstream. Thanks!

cc: @davehorsfall

@joshmoore joshmoore merged commit 8da1551 into ome:main May 13, 2026
3 checks passed
@jo-mueller
Copy link
Copy Markdown
Contributor

Interesting...I still the viewer on the landing page?

@lubianat
Copy link
Copy Markdown
Contributor Author

@jo-mueller @joshmoore

Apparently there was some unknown issue with the RTD build, though the preview (https://ngff--511.org.readthedocs.build/) worked fine.

grafik

I wonder if the build can just be re-triggered on RTD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants