RFC-4: give the orientation slot its range directly - #599
Merged
Conversation
Contributor
Automated Review URLs |
`orientation` carried a one-element `any_of` and no `range`, so the
generator emitted the default string range beside the reference:
"anyOf": [{"$ref": "#/$defs/AnatomicalOrientation"}, {"type": "null"}],
"type": "string"
Both apply, so the SpaceAxis branch rejected every oriented axis and null
alike; validators only pass through the generic Axis branch of the axes
anyOf. With the range stated directly the stray type is gone, the null
branch stays, and `orientation.ts` types the attribute
`AnatomicalOrientation` rather than `string`.
The markdown keeps the `orphan: true` front matter 0d68c8b added by hand.
vboussot
force-pushed
the
rfc4-orientation-slot-range
branch
from
September 1, 2026 00:55
0607f43 to
c6395ce
Compare
jo-mueller
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orientationonSpaceAxiscarries a one-elementany_ofand norange, so the generator emits the default string range beside the reference:Both constraints apply, so this branch of the schema rejects every oriented axis and
nullalike; a document only validates through the genericAxisbranch of the axesanyOf, which checks less thanSpaceAxismeans to.Stating the range directly removes the stray
type, keeps thenullbranch the description promises, and letsorientation.tstype the attributeAnatomicalOrientationrather thanstring. Regenerated withpixi run gen-all; the markdown keeps theorphan: truefront matter from 0d68c8b.Independent of #595, which touches the same generated files; whichever merges second regenerates cleanly.