Skip to content

Merge r2.8.3 develop into master#871

Merged
jaymengxy merged 69 commits intomasterfrom
develop
Apr 28, 2025
Merged

Merge r2.8.3 develop into master#871
jaymengxy merged 69 commits intomasterfrom
develop

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #???

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy self-assigned this Apr 24, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner April 24, 2025 14:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2025

PR Summary

Enhanced the Android build process with improved error handling, added comprehensive error reporting system across the app, and implemented secure script verification. Also improved deep linking functionality and backup mechanisms.

Changes

File Summary
.github/workflows/release.yml Added cleanup steps to remove sensitive files after build completion. Updated keystore handling to use base64 encoded production keystore and added Play Store upload via fastlane.
.gitignore Modified keystore file pattern from */keystore.jks to */**.jks to catch all JKS files.
Gemfile New file adding fastlane gem dependency for automated Play Store deployments.
app/build.gradle Added Firebase App Distribution configuration for release builds and included new X_SIGNATURE_KEY field.
app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt Implemented secure signature verification for Cadence scripts using NIST256P1 public key verification.
app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt Added error reporting for transaction failures and improved key validation with InvalidKeyException handling.
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt New helper class to manage pending deep link actions with SharedPreferences storage.
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt Added support for dapp, send, and buy deep link actions with network validation and value parsing.
app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt Implemented Instabug bug reporting configuration and added handling of pending deep link actions.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (30)
Files Processed (30)
  • .github/workflows/release.yml (5 hunks)
  • .gitignore (1 hunk)
  • Gemfile (1 hunk)
  • Gemfile.lock (1 hunk)
  • app/build.gradle (4 hunks)
  • app/src/main/assets/config/cadence_api.json (0 hunks)
  • app/src/main/java/com/flowfoundation/wallet/cache/AccountCacheManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/cache/UserPrefixCacheManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/instabug/InstabugUtils.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/account/AccountManager.kt (6 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/account/WalletFetcher.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/backup/GoogleDriveBackupUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt (5 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/drive/GoogleDriveAuthActivity.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/dropbox/DropboxBackupUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (8 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (4 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt (5 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Utils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/staking/StakingManager.kt (6 hunks)
  • app/src/main/java/com/flowfoundation/wallet/network/ApiService.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupDropboxViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupGoogleDriveViewModel.kt (4 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupRecoveryPhraseViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/backup/viewmodel/BackupSeedPhraseViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt (3 hunks)
Actionable Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt [144-146]

    possible issue: "Potential ambiguity in key selection"

Skipped Comments (3)
  • app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt [69-101]

    enhancement: "Network request timeout and key caching opportunity"

  • app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [134-148]

    possible issue: "Add bounds checking for value parsing"

  • .github/workflows/release.yml [82-89]

    best practice: "Improve cleanup step reliability"

@jaymengxy jaymengxy merged commit a8b247e into master Apr 28, 2025
5 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 30, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants