Conversation
Nialexsan/prod android
feat: use deeplink
feat: add cadence script signature
fix: wrongly modified bubble item title when dealing with clean code
fix: wallet notification null point time
fix: only navigate deeplink when user signed in
PR SummaryEnhanced the Android build process with improved error handling, added comprehensive error reporting system across the app, and implemented secure script verification. Also improved deep linking functionality and backup mechanisms. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (30)
- d789e05: feat: error code
- ae1008b: Force google client version
- f4f6625: Force 1.33.2
- 62b20c1: Downgrade gradle to 8.3
- e90a7a7: tweak proguard
- b8b4ccc: align gradle
- 542878a: align versions
- b0c35ea: update triplet play
- 63fe07b: fix set call
- 523b69d: downgrade troplet play to v2
- d0fcda1: downgrade triplet play
- b5a4c8e: downgrade triplet play
- 977f460: downgrade triplet.play
- 55d45fa: fix versions
- 52183c4: update deps
- 1806bda: force resolution
- 91d024c: downgrade version
- e7041b4: update google-http-client
- 95a2971: fix paths
- 1631d88: fix release
- ecd5c79: ref flow wallet kit
- 5d19ca8: decode prod keystore
- 9dcd722: add firebase distribution for release
- 74e3136: remove play from root
- 48b5999: revert org.jetbrains.kotlin.plugin.serialization
- 1c1d649: revert kotlin gradle plugin
- c7a8a7c: fix play version
- 0bcc195: Merge remote-tracking branch 'origin/develop' into nialexsan/prod-android
- 7bc3a95: test workflows
- c47d35b: android builds
Files Processed (30)
- .github/workflows/release.yml (5 hunks)
- .gitignore (1 hunk)
- Gemfile (1 hunk)
- Gemfile.lock (1 hunk)
- app/build.gradle (4 hunks)
- app/src/main/assets/config/cadence_api.json (0 hunks)
- app/src/main/java/com/flowfoundation/wallet/cache/AccountCacheManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/cache/UserPrefixCacheManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/instabug/InstabugUtils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/account/AccountManager.kt (6 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/account/WalletFetcher.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/backup/GoogleDriveBackupUtils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/drive/GoogleDriveAuthActivity.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/dropbox/DropboxBackupUtils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (8 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/CadenceExecutor.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt (5 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Utils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/staking/StakingManager.kt (6 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/ApiService.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/network/UserRegisterUtils.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupDropboxViewModel.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupGoogleDriveViewModel.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/backup/multibackup/viewmodel/BackupRecoveryPhraseViewModel.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/backup/viewmodel/BackupSeedPhraseViewModel.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/main/MainActivity.kt (3 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/manager/flowjvm/transaction/Transaction.kt [144-146]
possible issue: "Potential ambiguity in key selection"
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/manager/cadence/CadenceApiManager.kt [69-101]
enhancement: "Network request timeout and key caching opportunity"
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt [134-148]
possible issue: "Add bounds checking for value parsing"
-
.github/workflows/release.yml [82-89]
best practice: "Improve cleanup step reliability"
lmcmz
approved these changes
Apr 28, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)