Feature/sharedlib #143
Merged
Feature/sharedlib #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactor-sharedlib
# Conflicts: # flow/keys/keys.go
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
… refactor-sharedlib
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
QA: Add default output format
QA: Adjust JSON camelCase output
QA: Remove unused --name flag from flow accounts create
QA: Print account balance as UFix64
QA: Add transaction status alias with deprecation warning
QA: Preserve project commands
QA wrong flag value
…feature/sharedlib
# Conflicts: # flow/accounts/create/create.go
# Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #80
Refactor of CLI to introduce the concept of a shared library. Shared library is meant to be used by other software to leverage the functionality of the CLI and avoid code duplication.
Refactor also improves code architecture so we avoid having an implementation of domain logic in CLI commands and have them separated in service layer (services related to CLI functionality), gateway layer (network access functionality).
For contributor use:
masterbranchFiles changedin the Github PR explorer