Skip to content

Update Cadence 1.0 branch#1654

Merged
turbolent merged 16 commits into
feature/stable-cadencefrom
bastian/update-stable-cadence-3
Jun 13, 2024
Merged

Update Cadence 1.0 branch#1654
turbolent merged 16 commits into
feature/stable-cadencefrom
bastian/update-stable-cadence-3

Conversation

@turbolent

Copy link
Copy Markdown
Member

Description

Merge master into feature/stable-cadence


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 33.90%. Comparing base (649120d) to head (123c033).

Files Patch % Lines
internal/super/setup.go 0.00% 17 Missing ⚠️
internal/super/generate.go 69.23% 4 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1654      +/-   ##
==========================================================
+ Coverage                   33.80%   33.90%   +0.10%     
==========================================================
  Files                         100      100              
  Lines                        6331     6241      -90     
==========================================================
- Hits                         2140     2116      -24     
+ Misses                       3902     3841      -61     
+ Partials                      289      284       -5     
Flag Coverage Δ
unittests 33.90% <30.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent merged commit e4d0602 into feature/stable-cadence Jun 13, 2024
@turbolent turbolent deleted the bastian/update-stable-cadence-3 branch June 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants