Skip to content

Add additional information regarding probe_cc and probe_asn#45

Merged
mmaker merged 5 commits into
mainfrom
improve-doc-strings
Jun 29, 2026
Merged

Add additional information regarding probe_cc and probe_asn#45
mmaker merged 5 commits into
mainfrom
improve-doc-strings

Conversation

@LDiazN

@LDiazN LDiazN commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This PR will add documentation to some library function regarding the validation of probe_cc and probe_asn

@LDiazN LDiazN self-assigned this Jun 23, 2026

@mmaker mmaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm that AS007 and AS7 are not both valid AS numbers, and that similarly the country codes are UNIQUE when they reach this code. If you have a reference for it, it would be great.

@LDiazN

LDiazN commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

AS007 is not a valid ASN, we don't accept ASN strings where the integer part has leading 0s, see: ooni/backend#1221

@mmaker
mmaker merged commit c64cf2a into main Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants