ompi/monitoring: add .sh versionig to common monitoring lib #4842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Member
|
I don't see how this version is updated. Theoretically the monitoring library should be in sync with the MPI library version. |
Member
Author
Member
|
How do we ensure it is always in sync with the MPI library version ? |
Member
Author
|
It isn't / shouldn't be in sync with the MPI library version. That's not how We update it when the contents of the monitoring library are updated (just like all the other common libraries). It's one of the steps of the release process. |
bosilca
approved these changes
Feb 20, 2018
bwbarrett
approved these changes
Feb 20, 2018
jsquyres
deleted the
pr/add-so-versioning-to-ompi-common-monitoring-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
Refs #4838
FYI: @bosilca @clementFoyer
This should be PR'ed over to v3.1.x as well.