Migrate .js.erb files to .js#2997
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
- Coverage 69.77% 69.74% -0.03%
==========================================
Files 215 215
Lines 6839 6846 +7
==========================================
+ Hits 4772 4775 +3
- Misses 2067 2071 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkirchner
reviewed
Jul 4, 2025
This commit reverts the changes performed in 6541693, and uses local data attributes to pass settings to the frontend. The current solution is not ideal yet, but sufficient to continue with other important tasks.
MrSerth
force-pushed
the
ss/migrate_js_erb_to_js
branch
from
a58855e to
a8a4202
Compare
arkirchner
reviewed
Jul 4, 2025
arkirchner
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts the changes performed in 6541693, and uses local data attributes to pass settings to the frontend.
The current solution is not ideal yet, but sufficient to continue with other important tasks.
Relates to #2964.