Skip to content

MX-229: Split the grants in an independent file#109

Merged
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop
Apr 8, 2026
Merged

MX-229: Split the grants in an independent file#109
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop

Conversation

@IOhacker
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker commented Apr 8, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Reorganized Self Service database migrations by isolating user migration into a dedicated step for improved structure and maintainability.
    • Updated permission assignment migration sequencing.

@IOhacker IOhacker merged commit daaed73 into openMF:develop Apr 8, 2026
1 check passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1d9bfdc1-1d3a-416e-a6a0-06e05b0eb8bf

📥 Commits

Reviewing files that changed from the base of the PR and between 0dfb09e and 1ecf2ab.

📒 Files selected for processing (6)
  • src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/001-create-selfservice-initial-schema.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/002-migrate-selfservice-users.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/004-grant-selfservice-product-read-permissions.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/005-grant-selfservice-report-read-permissions.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/006-grant-selfservice-savings-account-read-permissions.xml

📝 Walkthrough

Walkthrough

The pull request refactors the self-service module's database migration structure by extracting user migration logic into a dedicated changeset file and renumbering subsequent permission-grant migrations to reflect their new sequential ordering in the master changelog.

Changes

Cohort / File(s) Summary
Master Changelog
src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
Updated includes to reference new initial schema file, added migration step for self-service users, and adjusted ordering of permission-grant parts (004, 005, 006).
Initial Schema Refactoring
src/main/resources/db/changelog/tenant/module/selfservice/parts/001-create-selfservice-initial-schema.xml
Removed changeset containing self-service user migration logic; migration moved to dedicated file.
User Migration
src/main/resources/db/changelog/tenant/module/selfservice/parts/002-migrate-selfservice-users.xml
New file containing changeset for migrating existing self-service users from m_appuser to m_appselfservice_user with precondition guards and duplicate prevention.
Permission Grants
src/main/resources/db/changelog/tenant/module/selfservice/parts/004-grant-selfservice-product-read-permissions.xml, src/main/resources/db/changelog/tenant/module/selfservice/parts/005-grant-selfservice-report-read-permissions.xml, src/main/resources/db/changelog/tenant/module/selfservice/parts/006-grant-selfservice-savings-account-read-permissions.xml
Updated changeset IDs to reflect new sequential ordering (ss-0004-1, ss-0005-1, ss-0006-1 respectively).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

⏱️ <10 Min Review

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant