Skip to content

MX-199: Fix the API 08. REQUEST A NEW SAVINGS ACCOUNT (SUBMIT APPLICATION)#125

Merged
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop
Apr 12, 2026
Merged

MX-199: Fix the API 08. REQUEST A NEW SAVINGS ACCOUNT (SUBMIT APPLICATION)#125
IOhacker merged 1 commit intoopenMF:developfrom
IOhacker:develop

Conversation

@IOhacker
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker commented Apr 12, 2026

MX-199: Fix the API 08. REQUEST A NEW SAVINGS ACCOUNT (SUBMIT APPLICATION)

Summary by CodeRabbit

  • New Features
    • Self Service Users can now create savings accounts.

@IOhacker IOhacker merged commit e703f84 into openMF:develop Apr 12, 2026
1 check passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f33471a-9792-49b1-a088-eed26c8b88b0

📥 Commits

Reviewing files that changed from the base of the PR and between f2751cc and 1f35935.

📒 Files selected for processing (2)
  • src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/010-grant-selfservice-savings-account-create-account-permissions.xml

📝 Walkthrough

Walkthrough

This pull request adds database migration configuration to grant the CREATE_SAVINGSACCOUNT permission to the Self Service User role. A new Liquibase changeset file is introduced and included in the module's master changelog.

Changes

Cohort / File(s) Summary
Liquibase Changelog Configuration
src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml, src/main/resources/db/changelog/tenant/module/selfservice/parts/010-grant-selfservice-savings-account-create-account-permissions.xml
Adds a new changeset file reference to the master changelog and creates the changeset that inserts a role-permission mapping granting CREATE_SAVINGSACCOUNT to the Self Service User role, with duplicate prevention via NOT EXISTS check.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

⏱️ <10 Min Review

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant