feat: add create group page#601
Merged
karantakalkar merged 1 commit intoopenMF:masterfrom May 22, 2020
Merged
Conversation
Collaborator
Author
|
Data Tables are not functional in demo.mifos.io beacuse the API response (post create group button-press) has no field for data-tables, |
karantakalkar
commented
Feb 9, 2020
karantakalkar
pushed a commit
to karantakalkar/web-app
that referenced
this pull request
Feb 22, 2020
Fixes: #212
karantakalkar
force-pushed
the
create-group
branch
from
0a8183e to
461b3f3
Compare
karantakalkar
commented
Feb 23, 2020
karantakalkar
pushed a commit
to karantakalkar/web-app
that referenced
this pull request
Feb 26, 2020
Fixes: #212
karantakalkar
force-pushed
the
create-group
branch
from
461b3f3 to
6c17407
Compare
karantakalkar
commented
Feb 26, 2020
karantakalkar
commented
Feb 27, 2020
karantakalkar
commented
Feb 27, 2020
spider0061
added a commit
to spider0061/web-app
that referenced
this pull request
Mar 1, 2020
added relevant comments ,removed the unnecessary white spaces and added white spaces whereever requried. Fixes: openMF#601
karantakalkar
pushed a commit
to karantakalkar/web-app
that referenced
this pull request
Mar 7, 2020
Fixes: #212
karantakalkar
force-pushed
the
create-group
branch
from
6c17407 to
299cc77
Compare
muskankhedia
suggested changes
May 11, 2020
Collaborator
muskankhedia
left a comment
muskankhedia
left a comment
There was a problem hiding this comment.
The UI looks nice. But when I tried to submit the form, it's displaying an error. Can you have a look if its the problem with the API or the data format that has been sent. Please attach a working GIF with the description.
karantakalkar
added
the
review requested
Collaborator
Author
|
@muskankhedia there are data tables to be implemented in this component as per communtiy app code, however they do not work in demo.mifos.io/staging.mifos.io, It functions similar to these servers though. |
Collaborator
|
Okay, that's fine. You can raise a JIRA ticket for the same if there is an error from the backend. Till then you can resolve the front-end issues. |
karantakalkar
pushed a commit
to karantakalkar/web-app
that referenced
this pull request
May 22, 2020
Fixes: #212
karantakalkar
force-pushed
the
create-group
branch
from
299cc77 to
148aeb4
Compare
Fixes: #212
karantakalkar
force-pushed
the
create-group
branch
from
148aeb4 to
f9740c8
Compare
karantakalkar
removed
the
review requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added routing to 'Create Group' button in Group's List View, designed the UI for Create Group Form
and connected it to the API.
Related issues and discussion
#212
Screenshots, if any
UI
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.