Skip to content

feat: add view bulk imports page#637

Merged
karantakalkar merged 1 commit intoopenMF:masterfrom
karantakalkar:bulk-imports
Jul 28, 2020
Merged

feat: add view bulk imports page#637
karantakalkar merged 1 commit intoopenMF:masterfrom
karantakalkar:bulk-imports

Conversation

@karantakalkar
Copy link
Copy Markdown
Collaborator

@karantakalkar karantakalkar commented Feb 29, 2020

Description

Added view bulk-import page for each bulk import in a single re-usable component configured download/upload template functionality and connected it to the API.

Notes:

  • This PR builds upon feat: add bulk import component #564, I propose to have bulk-imports as a component instead of a module.
  • Community App implementation involves 18 different controllers for each of the bulk imports, that was most likely the rationale of feat: add bulk import component #564 having bulk imports as module.
  • In this PR I have implemented bulk Imports component with a reusable view bulk imports sub-component reason being each of 18 controllers differ only in terms of categorical data which is:
    Name, Entity Type, URL Suffix, Number of Form Fields (Offices,Staff, Legal Form, None).
  • On the surface, the controllers seem to have different API requests, but they all are fetching same data (offices, staff) from different endpoints (clients template, centers template, offices).
  • I have defined a bulk-imports.ts file which contains categorical data for each of bulk imports.
    route parameter 'name' is used to fetch import specific data upon navigating to a particular import.
  • Client is the only import for which significant deviation was needed, because of 'Legal Form' Form Field.
  • Comparison b/w bulk-imports
    Screenshot from 2020-03-01 01-51-07
  • Rest of functionality is same across all bulk-imports.

Related issues and discussion

#633

Screenshots, if any

Screenshot from 2020-07-28 12-23-02

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

karantakalkar pushed a commit to karantakalkar/web-app that referenced this pull request Mar 7, 2020
karantakalkar pushed a commit to karantakalkar/web-app that referenced this pull request Mar 7, 2020
karantakalkar pushed a commit to karantakalkar/web-app that referenced this pull request Mar 7, 2020
@karantakalkar karantakalkar added gsoc 2020 Google Summer of Code 2020 p3 Low Priority and removed gsoc 2020 Google Summer of Code 2020 labels May 12, 2020
@muskankhedia muskankhedia added the review requested Pull Request requiring review by senior collaborators label May 14, 2020
Copy link
Copy Markdown
Collaborator

@muskankhedia muskankhedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There is no component for input field of type file and so html5 component has been used. If any other modules could be suggested that will be very helpful.

@abhaychawla Can you please have a review, @karantakalkar have followed a good approach to implement all the functionalities and reduce the modules at the same time.

karantakalkar pushed a commit to karantakalkar/web-app that referenced this pull request May 17, 2020
Comment thread src/app/organization/organization-routing.module.ts Outdated
Comment thread src/app/organization/organization-routing.module.ts
@muskankhedia
Copy link
Copy Markdown
Collaborator

@karantakalkar Can you make a gif/video displaying the download and upload of files in this section as I am continuously facing errors. And also file download, an encoded form is downloaded whereas in case of community app .xls file is downloaded. Is it the requirement as per now?

@karantakalkar
Copy link
Copy Markdown
Collaborator Author

karantakalkar commented May 17, 2020

The encoded file opens up to be xls only, in community pp implementation is very different, they open up a URL, whereas I am straightaway fetching from API.
Download API request work only for table downloads, I guess the scenario is same in commy app as well, check if there is any difference in API requests that this component makes and the one commy app page makes, as far as I know there wasn't.

@karantakalkar karantakalkar removed the p3 Low Priority label May 18, 2020
karantakalkar pushed a commit to karantakalkar/web-app that referenced this pull request May 18, 2020
@karantakalkar karantakalkar added gsoc 2020 Google Summer of Code 2020 and removed review requested Pull Request requiring review by senior collaborators labels Jul 27, 2020
@karantakalkar karantakalkar merged commit 571f711 into openMF:master Jul 28, 2020
@karantakalkar karantakalkar deleted the bulk-imports branch August 30, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc 2020 Google Summer of Code 2020

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants