Avoid rerunning stop review on blocked retries#549
Open
hogeheer499-commits wants to merge 1 commit into
Open
Conversation
hogeheer499-commits
marked this pull request as ready for review
July 24, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #548.
After a Stop hook blocks, Claude Code invokes it again with
stop_hook_active: true. The review gate currently ignores that flag, so a failed or blocking Codex review can run and block repeatedly until the harness cap is reached.This allows the retry to finish without starting another review, while still reporting any running Codex task on stderr. The regression test enables the review gate and verifies that an active stop retry produces no blocking decision.
Tests:
npm test(92 passed)npm run build