createBrokerEndpoint: honor injected platform in the Unix branch - #595
Closed
zebbern wants to merge 1 commit into
Closed
createBrokerEndpoint: honor injected platform in the Unix branch#595zebbern wants to merge 1 commit into
zebbern wants to merge 1 commit into
Conversation
zebbern
commented
Aug 5, 2026
zebbern
commented
The win32 branch already uses path.win32 explicitly, but the Unix branch built the socket path with the host path module, so calling createBrokerEndpoint(dir, "linux") on a Windows host produced "unix:\tmp\...\broker.sock". Use path.posix.join to match the injected platform. No behavior change on POSIX hosts, where path.join and path.posix.join are identical. Flips "createBrokerEndpoint uses Unix sockets on non-Windows platforms" from failing to passing on Windows hosts (CI only runs ubuntu-latest, so this was never visible there).
There was a problem hiding this comment.
Pull request overview
This PR fixes createBrokerEndpoint() so that, in the Unix-socket branch, it respects the injected platform argument rather than inheriting path separator behavior from the host OS, improving correctness when platform is overridden (e.g., in tests or cross-platform tooling).
Changes:
- Use
path.posix.join(...)for Unix socket endpoints to ensure POSIX separators regardless of host platform. - Add an inline comment documenting why
path.posixis required (mirroring the existing explicitpath.win32usage).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Withdrawing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.