fix: render status actions without raw HTML in the table cell - #599
Open
Wintersta7e wants to merge 1 commit into
Open
fix: render status actions without raw HTML in the table cell#599Wintersta7e wants to merge 1 commit into
Wintersta7e wants to merge 1 commit into
Conversation
The Actions column joined each action with a literal <br>, which Claude Code's markdown table renderer prints as text rather than a line break. A hard line break cannot survive a GFM table cell anyway -- escapeMarkdownCell already collapses newlines to spaces -- so join with a space, which is the first option the issue's own suggested fix lists. Fixes openai#495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actions column of the
/codex:statusjob table joins each action with a literal<br>, which Claude Code's markdown table renderer prints as text instead of interpreting as a line break.A hard line break can't survive a GFM table cell regardless —
escapeMarkdownCella few lines above already collapses newlines to spaces — so the issue's literal "Expected" output isn't reachable without moving the actions out of the table entirely. That felt like a UI change rather than a bug fix, so this takes the first option from the issue's own suggested fix and joins with a space:One line of production code. The existing
status shows phases, hints, and the latest finished jobtest asserted the<br>form and now asserts the space-joined one, so a regression in the separator fails the suite.Happy to switch to a nested list outside the cell instead if you'd rather have the actions on genuinely separate lines.
Fixes #495