-
Notifications
You must be signed in to change notification settings - Fork 587
feat: support model-native Deep Scan workers #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mdangelo/codex/preserve-url-scan-context
Are you sure you want to change the base?
Changes from all commits
205fb5d
5967299
c31d312
6480979
4b616a8
542a5a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,7 +72,7 @@ Confirm these plugin skills are available in the active runtime: | |
| - `$codex-security:validation` | ||
| - `$codex-security:attack-path-analysis` | ||
|
|
||
| The discovery tool launches Codex workers that may use Subagents v2. The active configuration must satisfy the deep profile's native-v2 requirement. The worker count is configured separately from this thread's subagent allowance. | ||
| The discovery tool manages its own workers independently of this thread's delegation runtime and subagent allowance. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Worker-pool independence does not remove the parent workflow's phase-skill dependencies: this same section still requires Useful? React with 👍 / 👎. |
||
|
|
||
| Continue after a `ready` result, explaining material warn or suggest limitations. For `blocked` or `incomplete` results with actionable remediation, first classify the session using `../../references/config-preflight.md`. In an interactive session, present the exact reasons, helper-reported config file path, and config changes, then use that reference's native `request_user_input` → `request_codex_security_user_input` → plain-chat fallback sequence before editing persistent configuration. Stop for the answer without creating a goal or starting discovery. In `codex exec`, headless, automation, or another non-interactive session, do not ask or wait; apply only helper-provided ordinary config patches to the helper's `user_config_path`, rerun preflight once, and continue only if it becomes `ready`. Never guess which Codex home is active or hide a higher-precedence conflict with a lower-precedence edit. If an interactive user declines required remediation, ask whether to cancel the durable desktop scan with `cancel_codex_security_scan` or leave it running for a later retry. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the active
CODEX_HOMEcontains legacyagents.max_threads, this profile now returnsready, but the bundledCodexSdkWorkerExecutor.runstill inherits that environment and explicitly passesfeatures.multi_agent_v2.enabled=trueto every discovery child. Codex rejects that V1/V2 combination, as the unchanged preflight documentation itself notes, so the newly admitted V1 configuration fails only afterstart_codex_security_deep_scanlaunches. Keep theconfig_absentcheck/remediation, or isolate the child configuration before declaring this parent setup compatible.Useful? React with 👍 / 👎.