refactor(workbench): remove duplicate migration relocation - #400
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Removes duplicate migration relocation while preserving historical database compatibility and transactional safety.
Summary
Remove a duplicate legacy migration relocation that is unreachable during normal workbench upgrades.
Changes
Testing
bun test tests-ts/runtime.test.ts tests-ts/deep-scan-workbench.test.ts --timeout 30000— passed, including colliding historical migrations, existing public databases, preserved completion warnings, rejected malformed histories, and Deep Scan schema repairs.pnpm run types— passed.python3 -I -BPython syntax validation — passed.git diff --check— passed.Risk and rollout
The outer normalizer already relocates the historical warning migration, or rejects conflicting history, before the inner execution-profile helper runs. Existing append-only migrations, persisted warning data, legacy execution settings, and unsupported-history checks remain unchanged.
Public disclosure review