Skip to content

refactor(workbench): remove duplicate migration relocation - #400

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-duplicate-migration-branch
Aug 14, 2026
Merged

refactor(workbench): remove duplicate migration relocation#400
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-duplicate-migration-branch

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove a duplicate legacy migration relocation that is unreachable during normal workbench upgrades.

Changes

  • Keep warning-migration relocation and conflicting-history checks in the existing outer migration normalizer.
  • Delete the inner execution-profile helper's duplicate relocation branch and related bookkeeping.

Testing

  • bun test tests-ts/runtime.test.ts tests-ts/deep-scan-workbench.test.ts --timeout 30000 — passed, including colliding historical migrations, existing public databases, preserved completion warnings, rejected malformed histories, and Deep Scan schema repairs.
  • pnpm run types — passed.
  • python3 -I -B Python syntax validation — passed.
  • git diff --check — passed.

Risk and rollout

The outer normalizer already relocates the historical warning migration, or rejects conflicting history, before the inner execution-profile helper runs. Existing append-only migrations, persisted warning data, legacy execution settings, and unsupported-history checks remain unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 2c72c53f6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2c72c53f6f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removes duplicate migration relocation while preserving historical database compatibility and transactional safety.

@mldangelo-oai
mldangelo-oai merged commit 216212b into main Aug 14, 2026
34 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-duplicate-migration-branch branch August 14, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants