Skip to content

test(runtime): share bundled runtime source loader - #407

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/share-bundled-runtime-test-loader
Aug 14, 2026
Merged

test(runtime): share bundled runtime source loader#407
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/share-bundled-runtime-test-loader

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Read and decompress the bundled runtime once for tests that inspect its immutable source.

Changes

  • Add a lazily cached runtime-source loader to the existing plugin test helper.
  • Reuse it in completed-scan handoff, prompt-only timeout, Deep reducer recovery, and Deep worker shutdown tests.
  • Keep each test's function evaluation and synthetic runtime dependencies independent.

Testing

  • bun test tests-ts/completed-scan-handoff.test.ts tests-ts/prompt-only-start-timeout.test.ts tests-ts/deep-scan-reducer-recovery.test.ts tests-ts/deep-scan-worker-shutdown.test.ts --timeout 30000 (9 passed).
  • bun test tests-ts/runtime.test.ts --timeout 30000 (117 passed; 7 platform-specific tests skipped).
  • pnpm --pm-on-fail=ignore run types.
  • prettier --check for all five changed test files.
  • git diff --check.

Risk and rollout

Test-only cleanup. Only immutable decompressed source is cached; evaluated functions, fixture objects, cancellation behavior, and production packages remain unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 543f79daf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 543f79daf5

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shared immutable runtime-source loading keeps each test fixture, evaluated function, and cancellation path isolated.

@mldangelo-oai
mldangelo-oai merged commit 3afb0c3 into main Aug 14, 2026
55 of 58 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/share-bundled-runtime-test-loader branch August 14, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants