test(runtime): share bundled runtime source loader - #407
Conversation
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Shared immutable runtime-source loading keeps each test fixture, evaluated function, and cancellation path isolated.
Summary
Read and decompress the bundled runtime once for tests that inspect its immutable source.
Changes
Testing
bun test tests-ts/completed-scan-handoff.test.ts tests-ts/prompt-only-start-timeout.test.ts tests-ts/deep-scan-reducer-recovery.test.ts tests-ts/deep-scan-worker-shutdown.test.ts --timeout 30000(9 passed).bun test tests-ts/runtime.test.ts --timeout 30000(117 passed; 7 platform-specific tests skipped).pnpm --pm-on-fail=ignore run types.prettier --checkfor all five changed test files.git diff --check.Risk and rollout
Test-only cleanup. Only immutable decompressed source is cached; evaluated functions, fixture objects, cancellation behavior, and production packages remain unchanged.
Public disclosure review