Skip to content

fix: preserve exact Windows filesystem identities - #494

Merged
faizan-oai merged 3 commits into
mainfrom
agent/fix-windows-exact-file-identities
Aug 18, 2026
Merged

fix: preserve exact Windows filesystem identities#494
faizan-oai merged 3 commits into
mainfrom
agent/fix-windows-exact-file-identities

Conversation

@faizan-oai

Copy link
Copy Markdown
Contributor

Summary

Severity: P1. Converting filesystem device and inode identifiers to JavaScript numbers can lose precision, allowing distinct Windows filesystem objects to compare equal during race checks. This keeps those identifiers exact.

Changes

  • Request bigint filesystem metadata for multiscan lock and output checks.
  • Request bigint filesystem metadata for runtime marketplace and credential-home checks.
  • Compare exact device and inode identities throughout the validation window.
  • Add regressions using colliding numeric projections of distinct bigint identities.

Testing

  • pnpm run format — passed.
  • pnpm run types — passed.
  • pnpm run build — passed.
  • Focused exact-identity regressions — 5 passed.
  • git diff --check origin/main...HEAD — passed.

Risk and rollout

Behavior changes only where an identity exceeds JavaScript's safe integer range or a replacement race occurs. The comparison remains device-plus-inode based, with no persistence or schema change.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@faizan-oai faizan-oai changed the title Use exact filesystem identities on Windows fix: preserve exact Windows filesystem identities Aug 17, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@faizan-oai
faizan-oai marked this pull request as ready for review August 17, 2026 20:18

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2fc599068f95 for correctness and simplification. One optional simplification around the privacy-check call. Keep the exact bigint identity comparisons.

This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.

Comment thread sdk/typescript/src/runtime.ts Outdated
mldangelo-oai
mldangelo-oai previously approved these changes Aug 17, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked 2fc5990. The earlier simplification suggestions remain non-blocking. Approving the reviewed head.

@faizan-oai
faizan-oai merged commit 8a058cb into main Aug 18, 2026
53 of 57 checks passed
@faizan-oai
faizan-oai deleted the agent/fix-windows-exact-file-identities branch August 18, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants