fix(windows): retry credential snapshots when files disappear - #708
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mldangelo-oai
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parallel startup can remove a temporary authentication file while another process inspects the credential home's ACLs. Windows PowerShell can report
System.IO.FileNotFoundException,Microsoft.PowerShell.Commands.GetAclCommandduring that inspection, aborting startup instead of retrying the incomplete snapshot.Changes
Testing
git diff --check: passed.Four unchanged release-label fixtures failed in each full run. An isolated run reproduced all four failures without importing either changed candidate file. One exact fixture call outside the test runner returned
EPERMfromuv_spawn, with undefined status and PID. Its underlying OS/policy/runtime cause remains unknown; no workaround was attempted. The seeded run also failed an authentication-home test while an extra local harness state-directory override took precedence over the fixture's home override. That extra harness override was omitted for the separately required unseeded run, where the authentication-home test passed; this was not an identical-environment replay. No passing local full suite is claimed.These local results use tested base
243436b. Latest main3bccb23changes neither patched file; hosted CI will check the current merge.The native replay verifies handling of the observed error, not an independent reproduction of the original deletion timing. No model-backed scan or machine-policy change was used.
Risk and rollout
This classifies one missing-descendant error for an existing bounded retry. It does not relax ACL rules, accept incomplete snapshots, or change CLI options, backend selection, locks, or authentication sources. Persistently changing snapshots still fail after three attempts. No migration is required; applicable hosted CI and review remain required.
Public disclosure review