Skip to content

feat(cli): make cost display optional - #881

Merged
ianw-oai merged 2 commits into
mainfrom
dev/ianw/show-cost
Sep 11, 2026
Merged

feat(cli): make cost display optional#881
ianw-oai merged 2 commits into
mainfrom
dev/ianw/show-cost

Conversation

@ianw-oai

@ianw-oai ianw-oai commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Scan logs show dollar estimates even when the user did not request them. Hide these estimates by default. Show them with --show-cost or when a cost limit is set.

Changes

  • Add --show-cost to scan, scan-components, scans resume, and scans rerun. The default is false.
  • Apply the setting to the dashboard, progress, summary, and verbose diagnostics.
  • Always show estimates for command-line, configured, and saved cost limits.
  • Update help and tests.

Testing

  • Focused CLI, component, dashboard, and configuration tests: 286 passed.
  • pnpm run types: passed.
  • pnpm run format: passed.
  • git diff --check: passed.
  • pnpm run test --seed 12345: 2,973 passed, 57 skipped, zero failures.
  • pnpm run test: 2,973 passed, 57 skipped, zero failures (seed 697217947).

Risk and rollout

This changes the default text output. Use --show-cost to restore dollar estimates. Token counts, cost tracking, cost limits, and saved/JSON data remain unchanged. No migration is required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the enhancement New feature or request label Sep 11, 2026
@ianw-oai
ianw-oai marked this pull request as ready for review September 11, 2026 05:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-11T05:25:15.181195Z 99bd1bc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ianw-oai ianw-oai changed the title feat(cli): [codex] make cost display optional feat(cli): make cost display optional Sep 11, 2026
@ianw-oai
ianw-oai merged commit 788b0bb into main Sep 11, 2026
48 checks passed
@ianw-oai
ianw-oai deleted the dev/ianw/show-cost branch September 11, 2026 05:38
@github-actions github-actions Bot mentioned this pull request Sep 11, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants