chore(deps-dev): bump @types/node from 22.19.17 to 26.4.1 in /sdk/typescript - #897
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.17 to 26.4.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.4.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mldangelo-oai
left a comment
There was a problem hiding this comment.
Reviewed the exact Node declaration upgrade and its filesystem overload change. The optional spy argument preserves bigint identity coverage without adding runtime behavior.
Current-head CI passes across all configured jobs. Local type, formatting, build, package, collision and source compatibility checks pass with TypeScript 7. Both full local Bun suites passed before the main merge (2,995 passed, 50 skipped, 0 failed each); the latest combined main tree also passes types and build:ci. No unresolved findings or public disclosure issues identified.
Summary
Upgrade the SDK’s Node.js declarations from 22.19.17 to 26.4.1 and keep the filesystem identity test compatible with the new
stat(path)overload.Changes
@types/node,undici-types, and the corresponding lockfile peer bindings.Testing
types,format,build:ci,build:examples, and package build with TypeScript 7 after merging main.pnpm packandcheck:package, including installed consumer types, CLI/SDK lifecycle, credential locking, MCP initialization, dashboard assets, and nested worker behavior.--seed 12345): 2,995 passed, 50 skipped, 0 failed. Retested with standard Git and fixture permissions after environment-specific failures.Risk and rollout
The new declarations support both TypeScript 5.7 and 7. Reviewed the exact shipped old/new declarations, upstream Node 26.4 type changes, and the relevant Node release notes. Production APIs used by the SDK remain available on supported Node 22, 24, and 26 runtimes; CI exercises the supported versions. This change adds no runtime API use or public CLI surface.
Public disclosure review