Skip to content

chore(deps-dev): bump @types/node from 22.19.17 to 26.4.1 in /sdk/typescript - #897

Merged
mldangelo-oai merged 3 commits into
mainfrom
dependabot/npm_and_yarn/sdk/typescript/types/node-26.4.1
Sep 11, 2026
Merged

chore(deps-dev): bump @types/node from 22.19.17 to 26.4.1 in /sdk/typescript#897
mldangelo-oai merged 3 commits into
mainfrom
dependabot/npm_and_yarn/sdk/typescript/types/node-26.4.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrade the SDK’s Node.js declarations from 22.19.17 to 26.4.1 and keep the filesystem identity test compatible with the new stat(path) overload.

Changes

  • Update @types/node, undici-types, and the corresponding lockfile peer bindings.
  • Merge main so validation covers the already-merged TypeScript 7 upgrade.
  • Make the existing filesystem spy’s options argument optional, matching Node’s API while preserving bigint inode collision coverage.

Testing

  • Passed SDK types, format, build:ci, build:examples, and package build with TypeScript 7 after merging main.
  • Passed both focused numeric-identity collision tests with TypeScript 7 and Node 26 types.
  • Passed compiled plugin source compatibility checks and their 9 Node tests.
  • Passed pnpm pack and check:package, including installed consumer types, CLI/SDK lifecycle, credential locking, MCP initialization, dashboard assets, and nested worker behavior.
  • Local Bun suite before merging main (--seed 12345): 2,995 passed, 50 skipped, 0 failed. Retested with standard Git and fixture permissions after environment-specific failures.

Risk and rollout

The new declarations support both TypeScript 5.7 and 7. Reviewed the exact shipped old/new declarations, upstream Node 26.4 type changes, and the relevant Node release notes. Production APIs used by the SDK remain available on supported Node 22, 24, and 26 runtimes; CI exercises the supported versions. This change adds no runtime API use or public CLI surface.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.17 to 26.4.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.4.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 11, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-11T20:27:57.408033Z 5ba6694 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact Node declaration upgrade and its filesystem overload change. The optional spy argument preserves bigint identity coverage without adding runtime behavior.

Current-head CI passes across all configured jobs. Local type, formatting, build, package, collision and source compatibility checks pass with TypeScript 7. Both full local Bun suites passed before the main merge (2,995 passed, 50 skipped, 0 failed each); the latest combined main tree also passes types and build:ci. No unresolved findings or public disclosure issues identified.

@mldangelo-oai
mldangelo-oai merged commit 30585c4 into main Sep 11, 2026
58 of 73 checks passed
@mldangelo-oai
mldangelo-oai deleted the dependabot/npm_and_yarn/sdk/typescript/types/node-26.4.1 branch September 11, 2026 20:49
@github-actions github-actions Bot mentioned this pull request Sep 12, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant