build(linux-sandbox): always compile vendored bubblewrap on Linux; remove CODEX_BWRAP_ENABLE_FFI #11498
+153
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 16b4440.
zbarsky-openai
force-pushed
the
codex/viyatb/always-bwrap-linux
branch
from
ed7c52d to
a157259
Compare
viyatb-oai
requested review from
bolinfest,
jif-oai and
zbarsky-openai
and removed request for
jif-oai
…odex into codex/viyatb/always-bwrap-linux
bolinfest
reviewed
Feb 12, 2026
bolinfest
reviewed
Feb 12, 2026
bolinfest
reviewed
Feb 12, 2026
bolinfest
reviewed
Feb 12, 2026
bolinfest
reviewed
Feb 12, 2026
bolinfest
approved these changes
Feb 12, 2026
Collaborator
|
Test failures are due to #11545, will merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the temporary
CODEX_BWRAP_ENABLE_FFIflag and makes Linux builds always compile vendored bubblewrap support forcodex-linux-sandbox.Changes
CODEX_BWRAP_ENABLE_FFIgating fromcodex-rs/linux-sandbox/build.rs.codex-rs/linux-sandbox/src/vendored_bwrap.rsto remove references toCODEX_BWRAP_ENABLE_FFI.CODEX_BWRAP_ENABLE_FFIenv wiring from:.github/workflows/rust-ci.yml.github/workflows/bazel.yml.github/workflows/rust-release.yml