fix: make project_doc skill-render tests deterministic #11545
Merged
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
project_doc::tests::skills_are_appended_to_project_docandproject_doc::tests::skills_render_without_project_docwere assuming a single synthetic skill in test setup, but they calledload_skills(&cfg), which loads from repo/user/system roots.That made the assertions environment-dependent. After #11531 added
.codex/skills/test-tui/SKILL.md, the repo-scopedtest-tuiskill began appearing in these test outputs and exposed the flake.What Changed
codex-rs/core/src/project_doc.rsthat loads skills from an explicit root viaload_skills_from_roots.codex_home/skillswithSkillScope::User.load_skills(&cfg):skills_are_appended_to_project_docskills_render_without_project_docThis keeps the tests focused on the fixture skills they create, independent of ambient repo/home skills.
Verification
cargo test -p codex-core project_doc::tests::skills_render_without_project_doc -- --exactcargo test -p codex-core project_doc::tests::skills_are_appended_to_project_doc -- --exact