fix(sandbox): fix bwrap lookup for multi-entry PATH#15973
Merged
viyatb-oai merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
viyatb-oai
changed the title
Collaborator
|
@codex review |
etraut-openai
approved these changes
Mar 27, 2026
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATHbefore running systembwraplookupbwrapskip behavior intactWhy
The PATH-based lookup added in #15791 still wrapped the raw
PATHenvironment value as a singlePathBufbefore passing it throughjoin_paths(). On Unix, a normal multi-entryPATHcontains:, so that wrapper path is invalid as one path element and the lookup returnsNone.That made Codex behave as if no system
bwrapwas installed even whenbwrapwas available onPATH, which is what users in #15340 were still hitting on0.117.0-alpha.25.Impact
System
bwrapdiscovery now works with normal multi-entryPATHvalues instead of silently falling back to the vendored binary.Fixes #15340.
Validation
just fmtcargo test -p codex-sandboxingcargo test -p codex-linux-sandboxjust fix -p codex-sandboxingjust argument-comment-lint