Conversation
bolinfest
added a commit
that referenced
this pull request
Apr 14, 2026
## Why This stack adds a new Bazel CI lane that verifies Rust code behind `cfg(not(debug_assertions))`, but adding that job directly to `.github/workflows/bazel.yml` would duplicate the same setup in multiple places. Extracting the shared setup first keeps the follow-up change easier to review and reduces the chance that future Bazel workflow edits drift apart. ## What Changed - Added `.github/actions/prepare-bazel-ci/action.yml` as a composite action for the Bazel job bootstrap shared by multiple workflow jobs. - Moved the existing Bazel setup, repository-cache restore, and execution-log setup behind that action. - Updated the `test` and `clippy` jobs in `.github/workflows/bazel.yml` to call `prepare-bazel-ci`. - Exposed `repository-cache-hit` and `repository-cache-path` outputs so callers can keep the existing cache-save behavior without duplicating the restore step. ## Verification - Parsed `.github/workflows/bazel.yml` as YAML locally after rebasing the stack. - CI will exercise the refactored jobs end to end. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/17704). * #17705 * __->__ #17704
bolinfest
force-pushed
the
pr17705
branch
2 times, most recently
from
0b6df04 to
21f484a
Compare
pakrym-oai
approved these changes
Apr 14, 2026
Collaborator
|
we may need to separate bazel cache snapshots for release build vs regular build as they produce different artifacts (and there is only one snapshot per key, so first one wins or smth) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainrecently needed #17691 because code behindcfg(not(debug_assertions))was not being compiled by the Bazel PR workflow. Our existing CI only built the fast/debug configuration, so PRs could stay green while release-only Rust code still failed to compile. This PR adds a release-style compile check that is cheap enough to run on every PR.What Changed
verify-release-buildjob to.github/workflows/bazel.yml.--compilation_mode=fastbuildwhile forcing Rust to compile with-Cdebug-assertions=no, which makescfg(not(debug_assertions))true without also turning on release optimizations or debug-info generation..github/workflows/bazel.ymlandscripts/list-bazel-release-targets.shto make the job's intent and target scope explicit.repository-cache-hitoutput fromprepare-bazel-ci.prepare-bazel-ciaction from the parent PR so the new job does not duplicate Bazel setup boilerplate.Verification
bazel aqueryon//codex-rs/tui:codex-tuito confirm the Rust compile still usesopt-level=0anddebuginfo=0while passing-Cdebug-assertions=no..github/workflows/bazel.ymlas YAML locally.bash -n scripts/list-bazel-release-targets.sh.