[2/8] Support piped stdin in exec process API#17985
Closed
aibrahim-oai wants to merge 1 commit intoopenai:dev/remote-mcp-env-configfrom
Closed
[2/8] Support piped stdin in exec process API#17985aibrahim-oai wants to merge 1 commit intoopenai:dev/remote-mcp-env-configfrom
aibrahim-oai wants to merge 1 commit intoopenai:dev/remote-mcp-env-configfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf207553e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aibrahim-oai
changed the title
aibrahim-oai
changed the title
aibrahim-oai
changed the title
aibrahim-oai
changed the title
pakrym-oai
reviewed
Apr 16, 2026
| /// Controls whether the executor keeps a writable stdin pipe for this | ||
| /// process. | ||
| /// | ||
| /// Normal non-interactive exec commands use `Closed` so programs that read |
pakrym-oai
reviewed
Apr 16, 2026
| /// stdin see EOF immediately. Remote MCP stdio uses `Piped` because rmcp | ||
| /// must write JSON-RPC request bytes to the child process stdin after the | ||
| /// process has started. | ||
| pub stdin: ExecStdinMode, |
pakrym-oai
reviewed
Apr 16, 2026
| env_policy: /*env_policy*/ None, | ||
| env: Default::default(), | ||
| tty: false, | ||
| stdin: ExecStdinMode::Closed, |
Collaborator
There was a problem hiding this comment.
New feature needs testing
Add an explicit stdin mode to process/start so non-tty processes can either keep stdin closed or expose a writable pipe. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
dev/remote-mcp-env-config
branch
from
95d69db to
e776798
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-exec-stdin
branch
from
cf20755 to
315ecdf
Compare
Collaborator
Author
|
Recreated as #18086 from an openai/codex head branch so internal CI uses the normal credentials path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack