[2/8] Support piped stdin in exec process API#18086
[2/8] Support piped stdin in exec process API#18086aibrahim-oai wants to merge 1 commit intodev/remote-mcp-env-configfrom
Conversation
Add an explicit stdin mode to process/start so non-tty processes can either keep stdin closed or expose a writable pipe. Co-authored-by: Codex <noreply@openai.com>
e776798 to
d91856d
Compare
315ecdf to
4942819
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 315ecdfb2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// stdin see EOF immediately. Remote MCP stdio uses `Piped` because rmcp | ||
| /// must write JSON-RPC request bytes to the child process stdin after the | ||
| /// process has started. | ||
| pub stdin: ExecStdinMode, |
There was a problem hiding this comment.
Preserve backward-compatible default for stdin mode
Make stdin optional at the wire level. As added, ExecParams now requires stdin, so older process/start clients that omit it fail deserialization with invalid params instead of starting a process. There are existing JSON callers that don't send this field (for example in websocket process tests), so this change introduces a protocol break. Add a serde default of Closed.
Useful? React with 👍 / 👎.
Summary
Stack