Skip to content

[2/8] Support piped stdin in exec process API#18086

Open
aibrahim-oai wants to merge 1 commit intodev/remote-mcp-env-configfrom
dev/remote-mcp-exec-stdin
Open

[2/8] Support piped stdin in exec process API#18086
aibrahim-oai wants to merge 1 commit intodev/remote-mcp-env-configfrom
dev/remote-mcp-exec-stdin

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Apr 16, 2026

Summary

  • Add an explicit stdin mode to process/start.
  • Keep normal non-interactive exec stdin closed while allowing pipe-backed processes.

Stack

o  #18027 [8/8] Fail exec client operations after disconnect
│
o  #18025 [7/8] Cover MCP stdio tests with executor placement
│
o  #18089 [6/8] Wire remote MCP stdio through executor
│
o  #18088 [5/8] Add executor process transport for MCP stdio
│
o  #18087 [4/8] Abstract MCP stdio server launching
│
o  #18020 [3/8] Add pushed exec process events
│
@  #18086 [2/8] Support piped stdin in exec process API
│
o  #18085 [1/8] Add MCP server environment config
│
o  main

Add an explicit stdin mode to process/start so non-tty processes can either keep stdin closed or expose a writable pipe.

Co-authored-by: Codex <noreply@openai.com>
@aibrahim-oai aibrahim-oai force-pushed the dev/remote-mcp-env-config branch from e776798 to d91856d Compare April 16, 2026 06:20
@aibrahim-oai aibrahim-oai force-pushed the dev/remote-mcp-exec-stdin branch from 315ecdf to 4942819 Compare April 16, 2026 06:20
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 315ecdfb2c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

/// stdin see EOF immediately. Remote MCP stdio uses `Piped` because rmcp
/// must write JSON-RPC request bytes to the child process stdin after the
/// process has started.
pub stdin: ExecStdinMode,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve backward-compatible default for stdin mode

Make stdin optional at the wire level. As added, ExecParams now requires stdin, so older process/start clients that omit it fail deserialization with invalid params instead of starting a process. There are existing JSON callers that don't send this field (for example in websocket process tests), so this change introduces a protocol break. Add a serde default of Closed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant