Skip to content

[codex] Add owner nudge app-server API#18220

Merged
richardopenai merged 2 commits intomainfrom
codex/workspace-owner-nudge-nonfunctional
Apr 18, 2026
Merged

[codex] Add owner nudge app-server API#18220
richardopenai merged 2 commits intomainfrom
codex/workspace-owner-nudge-nonfunctional

Conversation

@richardopenai
Copy link
Copy Markdown
Contributor

@richardopenai richardopenai commented Apr 16, 2026

Summary

Second PR in the split from #17956. Stacked on #18227.

  • adds app-server v2 protocol/schema support for account/sendAddCreditsNudgeEmail
  • adds the backend-client send_add_credits_nudge_email request and request body mapping
  • handles the app-server request with auth checks, backend call, and cooldown mapping
  • adds the disabled workspace_owner_usage_nudge feature flag and focused app-server/backend tests

Validation

  • cargo test -p codex-backend-client
  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-app-server rate_limits
  • cargo test -p codex-tui workspace_
  • cargo test -p codex-tui status_
  • just fmt
  • just fix -p codex-backend-client
  • just fix -p codex-app-server-protocol
  • just fix -p codex-app-server
  • just fix -p codex-tui

@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 66b2cdc to dfbe1af Compare April 16, 2026 23:06
@richardopenai richardopenai changed the title [codex] Add owner nudge app-server plumbing [codex] Add owner nudge app-server API Apr 16, 2026
@richardopenai richardopenai changed the base branch from main to codex/rate-limit-reached-type-plumbing April 16, 2026 23:07
@richardopenai richardopenai force-pushed the codex/rate-limit-reached-type-plumbing branch 3 times, most recently from 63b0730 to f2e4dbf Compare April 17, 2026 03:01
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the feature flag

Comment thread codex-rs/features/src/lib.rs Outdated
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from dfbe1af to 3d88a20 Compare April 17, 2026 05:56
@richardopenai richardopenai force-pushed the codex/rate-limit-reached-type-plumbing branch from 53fac2f to 3a3697d Compare April 17, 2026 06:07
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used in the 3rd one

@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 3ce34de to 6c363e5 Compare April 17, 2026 06:15
@richardopenai richardopenai force-pushed the codex/rate-limit-reached-type-plumbing branch 2 times, most recently from 08978c8 to 4edc250 Compare April 17, 2026 16:27
Base automatically changed from codex/rate-limit-reached-type-plumbing to main April 17, 2026 20:37
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 6c363e5 to 458f7ca Compare April 17, 2026 20:53
@richardopenai richardopenai marked this pull request as ready for review April 17, 2026 22:34
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 458f7ca795

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/backend-client/src/client.rs
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 458f7ca to 11b30a1 Compare April 17, 2026 23:58
@richardopenai richardopenai merged commit 6b39d0c into main Apr 18, 2026
25 checks passed
@richardopenai richardopenai deleted the codex/workspace-owner-nudge-nonfunctional branch April 18, 2026 04:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants