Skip to content

[codex] Add workspace owner usage nudge UI#18221

Merged
richardopenai merged 4 commits intomainfrom
codex/workspace-owner-usage-nudge-stacked
Apr 20, 2026
Merged

[codex] Add workspace owner usage nudge UI#18221
richardopenai merged 4 commits intomainfrom
codex/workspace-owner-usage-nudge-stacked

Conversation

@richardopenai
Copy link
Copy Markdown
Contributor

@richardopenai richardopenai commented Apr 16, 2026

Summary

Third PR in the split from #17956. Stacked on #18220.

  • shows workspace-owner/member-specific rate-limit messages behind workspace_owner_usage_nudge
  • prompts workspace members to notify the owner or request a usage-limit increase
  • sends the confirmed nudge through the app-server API and renders completion feedback
  • adds focused TUI snapshot coverage for prompts and completion states
  • feature gate

Validation

  • cargo test -p codex-backend-client
  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-app-server rate_limits
  • cargo test -p codex-tui workspace_
  • cargo test -p codex-tui status_
  • just fmt
  • just fix -p codex-backend-client
  • just fix -p codex-app-server-protocol
  • just fix -p codex-app-server
  • just fix -p codex-tui

@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 66b2cdc to dfbe1af Compare April 16, 2026 23:06
@richardopenai richardopenai force-pushed the codex/workspace-owner-usage-nudge-stacked branch 2 times, most recently from ad37567 to 3732e24 Compare April 17, 2026 05:56
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from dfbe1af to 3d88a20 Compare April 17, 2026 05:56
@richardopenai richardopenai force-pushed the codex/workspace-owner-usage-nudge-stacked branch from 3732e24 to 033bd49 Compare April 17, 2026 06:05
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 3ce34de to 6c363e5 Compare April 17, 2026 06:15
@richardopenai richardopenai force-pushed the codex/workspace-owner-usage-nudge-stacked branch from 033bd49 to 7c86c66 Compare April 17, 2026 06:15
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 6c363e5 to 458f7ca Compare April 17, 2026 20:53
@richardopenai richardopenai force-pushed the codex/workspace-owner-usage-nudge-stacked branch from 7c86c66 to 6766cfb Compare April 17, 2026 20:53
@richardopenai richardopenai force-pushed the codex/workspace-owner-nudge-nonfunctional branch from 458f7ca to 11b30a1 Compare April 17, 2026 23:58
@richardopenai richardopenai force-pushed the codex/workspace-owner-usage-nudge-stacked branch from 6766cfb to 800263a Compare April 17, 2026 23:58
Base automatically changed from codex/workspace-owner-nudge-nonfunctional to main April 18, 2026 04:42
@richardopenai richardopenai marked this pull request as ready for review April 20, 2026 04:43
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 800263acca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +2733 to +2736
if is_codex_limit
&& let Some(rate_limit_reached_type) = snapshot.rate_limit_reached_type
{
self.codex_rate_limit_reached_type = Some(rate_limit_reached_type);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Clear stale reached-type cache when snapshot is unclassified

on_rate_limit_snapshot only updates codex_rate_limit_reached_type when the incoming codex snapshot has a value. When rate_limit_reached_type is None, the previous value is retained, but on_rate_limit_error later uses this cache to pick owner/member-specific messaging and nudge behavior. That can surface the wrong prompt/message after account state changes and a later 429 arrives without classification.

Useful? React with 👍 / 👎.

@richardopenai richardopenai enabled auto-merge (squash) April 20, 2026 05:08
@richardopenai richardopenai disabled auto-merge April 20, 2026 05:23
@richardopenai
Copy link
Copy Markdown
Contributor Author

/merge

@richardopenai richardopenai enabled auto-merge (squash) April 20, 2026 05:24
@richardopenai richardopenai merged commit 3c75f9b into main Apr 20, 2026
25 checks passed
@richardopenai richardopenai deleted the codex/workspace-owner-usage-nudge-stacked branch April 20, 2026 05:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants