[codex] Add workspace owner usage nudge UI#18221
Conversation
66b2cdc to
dfbe1af
Compare
ad37567 to
3732e24
Compare
dfbe1af to
3d88a20
Compare
3732e24 to
033bd49
Compare
3ce34de to
6c363e5
Compare
033bd49 to
7c86c66
Compare
6c363e5 to
458f7ca
Compare
7c86c66 to
6766cfb
Compare
458f7ca to
11b30a1
Compare
6766cfb to
800263a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 800263acca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if is_codex_limit | ||
| && let Some(rate_limit_reached_type) = snapshot.rate_limit_reached_type | ||
| { | ||
| self.codex_rate_limit_reached_type = Some(rate_limit_reached_type); |
There was a problem hiding this comment.
Clear stale reached-type cache when snapshot is unclassified
on_rate_limit_snapshot only updates codex_rate_limit_reached_type when the incoming codex snapshot has a value. When rate_limit_reached_type is None, the previous value is retained, but on_rate_limit_error later uses this cache to pick owner/member-specific messaging and nudge behavior. That can surface the wrong prompt/message after account state changes and a later 429 arrives without classification.
Useful? React with 👍 / 👎.
|
/merge |
Summary
Third PR in the split from #17956. Stacked on #18220.
workspace_owner_usage_nudgeValidation
cargo test -p codex-backend-clientcargo test -p codex-app-server-protocolcargo test -p codex-app-server rate_limitscargo test -p codex-tui workspace_cargo test -p codex-tui status_just fmtjust fix -p codex-backend-clientjust fix -p codex-app-server-protocoljust fix -p codex-app-serverjust fix -p codex-tui