refactor: simplify agent identity auth#18758
Closed
efrazer-oai wants to merge 2 commits intodev/efrazer/agent-identity-cratefrom
Closed
refactor: simplify agent identity auth#18758efrazer-oai wants to merge 2 commits intodev/efrazer/agent-identity-cratefrom
efrazer-oai wants to merge 2 commits intodev/efrazer/agent-identity-cratefrom
Conversation
fc10fb2 to
7f460c5
Compare
5259e6a to
375d41a
Compare
7f460c5 to
117d4ac
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack context
This PR is part of the cleanup for the merged agent identity stack.
Reference stack: https://github.com/openai/codex/pull/17387/changes
The old stack mixed three concerns:
The desired final state is smaller:
codex-agent-identityAgentIdentityauth modeAuthorizationheader valueWhy
The task lifecycle design is the part of the old stack with the most uncertainty.
The old code created task ids around Codex threads, persisted them in rollout/session state, and threaded them through replay and resume paths. That made a temporary auth requirement part of core Codex history handling.
This PR removes that lifecycle layer.
What changed
Boundary
This PR does not add the new programmatic auth model.
After this PR, Codex no longer owns a per-thread task lifecycle. The next PR adds the replacement model: explicit
AgentIdentityauth with one process task held in runtime memory.Tests
Tests: targeted Rust checks for core/session/auth rollback paths and CI.