fix: fully revert agent identity runtime wiring#18757
Merged
efrazer-oai merged 9 commits intomainfrom Apr 21, 2026
Merged
Conversation
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
2 times, most recently
from
7f460c5 to
117d4ac
Compare
efrazer-oai
changed the title
This was referenced Apr 21, 2026
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
117d4ac to
b647fd7
Compare
efrazer-oai
changed the title
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
b647fd7 to
5acde03
Compare
efrazer-oai
changed the title
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
5acde03 to
342ad35
Compare
pakrym-oai
reviewed
Apr 21, 2026
| pub fn build_abom(session_source: SessionSource) -> AgentBillOfMaterials { | ||
| AgentBillOfMaterials { | ||
| agent_version: env!("CARGO_PKG_VERSION").to_string(), | ||
| agent_harness_id: match &session_source { |
Collaborator
There was a problem hiding this comment.
why are we transforming this?
Collaborator
There was a problem hiding this comment.
we already have plenty issues mapping values we send in telemetry
pakrym-oai
reviewed
Apr 21, 2026
| )) | ||
| } | ||
|
|
||
| pub fn normalize_chatgpt_base_url(chatgpt_base_url: &str) -> String { |
Collaborator
There was a problem hiding this comment.
it is suspicious that we need to do so much url cleanup
pakrym-oai
approved these changes
Apr 21, 2026
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
342ad35 to
517af31
Compare
efrazer-oai
changed the title
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
2 times, most recently
from
3a0d4c3 to
81a4782
Compare
)" This reverts commit 904c751.
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
81a4782 to
c787e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fully reverts the previously merged Agent Identity runtime integration from the old stack:
https://github.com/openai/codex/pull/17387/changes
It removes the Codex-side task lifecycle wiring, rollout/session persistence, feature flag plumbing, lazy
auth.jsonmutation, background task auth paths, and request callsite changes introduced by that stack.This leaves the repo in a clean pre-AgentIdentity integration state so the follow-up PRs can reintroduce the pieces in smaller reviewable layers.
Stack
Testing
Tests: targeted Rust checks, cargo-shear, Bazel lock check, and CI.