Add MITM hook config model#18868
Conversation
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/core/src/network_proxy_loader.rs
Lines 135 to 171 in c0521ac
network.mitm and network.mitm_hooks were added, but trusted-layer constraint derivation does not track them. As a result, higher-precedence user/project config can disable or replace managed MITM hooks without constraint rejection, weakening centrally enforced HTTPS policy.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex review item about managed constraints for MITM hook fields: this is valid, and it is tracked in Linear as AGE 248. Why it is not in this PR: PR 18868 is now only the typed MITM hook config model. Enforcing trusted constraints for This remains blocked before dogfood or feature gate rollout. Trusted config must prevent user or project config from disabling or replacing managed MITM hooks before protected destinations are enabled. The separate method policy ordering concern is tracked in Linear as AGE 247. |
2f3ea9b to
fe69321
Compare
b11141b to
5c1bf13
Compare
|
Thanks. This is intentional for this PR. The MITM feature is still being built. PR 18868 only lands the typed config model. It does not turn on enforcement. Enforcement will come in later PRs after the user flow, logging, feature gate, and protected destination policy are ready. That avoids surprising users while the rollout pieces are still being developed. The follow up work is tracked in Linear:
Those tasks are required before dogfood or feature gate rollout. |
a425e22 to
6f6a861
Compare
winston-openai
left a comment
There was a problem hiding this comment.
LGTM, though you may still want to consider splitting this PR up into smaller, more reviewable chunks
|
it may also be worth keeping the config shape internal rather than exposing it in the |
6f6a861 to
f7779d8
Compare
f7779d8 to
af01135
Compare
Stack
Why
Summary
Validation
Notes