Wire MITM hooks into runtime enforcement#20659
Conversation
fe69321 to
b6be46a
Compare
ec08b07 to
6edf86c
Compare
b6be46a to
c6c6db9
Compare
6edf86c to
03765b9
Compare
c6c6db9 to
12243bc
Compare
03765b9 to
1c1ed25
Compare
12243bc to
bba0ec9
Compare
a5db4d3 to
c4188b4
Compare
8447355 to
8870e65
Compare
c4188b4 to
912d8e7
Compare
8870e65 to
fdfdc17
Compare
912d8e7 to
16c939f
Compare
fdfdc17 to
0ee61a2
Compare
16c939f to
0bf18c0
Compare
0ee61a2 to
b11141b
Compare
0bf18c0 to
011f536
Compare
b11141b to
5c1bf13
Compare
c444377 to
e342e00
Compare
a425e22 to
6f6a861
Compare
e342e00 to
599ba13
Compare
winston-openai
left a comment
There was a problem hiding this comment.
LGTM for the HTTP CONNECT path. One follow up I think we need to think through: SOCKS5 is also enabled by default and currently still opens a raw tunnel in full mode but the hooks don't apply. We either need to apply equivalent hook enforcement to SOCKS5 TCP HTTPS flows or fail closed for hooked hosts on SOCKS5 so folks can't bypass the hook policy. There's also the open question about what to do about the SOCKS5 UDP setup; my thought is we detect if it's HTTP3/QUIC and if so, mitm it, apply hooks and forward the requests, and otherwise proxy it (or fail closed - maybe there's another config option).
We can discuss this though - these things should be separate follow up PRs. I just want to call them out so that hooks are being applied properly
6f6a861 to
f7779d8
Compare
599ba13 to
5c28c96
Compare
|
Thanks. I agree. I left SOCKS5 as follow up work. This PR only covers the HTTP CONNECT path. The next task should decide whether SOCKS5 uses the same hook path or blocks hooked hosts until that path is ready. It should also cover UDP and QUIC before rollout. |
f7779d8 to
af01135
Compare
5c28c96 to
2c9ccbe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c9ccbe030
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Stack
Why
Summary
Validation