Open
Conversation
This was referenced Apr 21, 2026
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
517af31 to
3a0d4c3
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
efedf63 to
e02b5c8
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
3a0d4c3 to
81a4782
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
e02b5c8 to
570e766
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-crate
branch
from
81a4782 to
c787e22
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
570e766 to
5f85536
Compare
efrazer-oai
added a commit
that referenced
this pull request
Apr 21, 2026
## Summary This PR fully reverts the previously merged Agent Identity runtime integration from the old stack: https://github.com/openai/codex/pull/17387/changes It removes the Codex-side task lifecycle wiring, rollout/session persistence, feature flag plumbing, lazy `auth.json` mutation, background task auth paths, and request callsite changes introduced by that stack. This leaves the repo in a clean pre-AgentIdentity integration state so the follow-up PRs can reintroduce the pieces in smaller reviewable layers. ## Stack 1. This PR: full revert 2. #18871: move Agent Identity business logic into a crate 3. #18785: add explicit AgentIdentity auth mode and startup task allocation 4. #18811: migrate auth callsites through AuthProvider ## Testing Tests: targeted Rust checks, cargo-shear, Bazel lock check, and CI.
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
5f85536 to
52fc527
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52fc527e79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
approved these changes
Apr 22, 2026
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
52fc527 to
f68e579
Compare
efrazer-oai
force-pushed
the
dev/efrazer/agent-identity-lib
branch
from
f68e579 to
d593930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
codex-agent-identityas an isolated crate for Agent Identity business logic.The crate owns:
It does not wire AgentIdentity into
auth.json,AuthManager, rollout state, or request callsites. That integration happens in later PRs.Reference old stack: https://github.com/openai/codex/pull/17387/changes
Stack
CODEX_AGENT_IDENTITYTesting
Tests: targeted Rust checks, cargo-shear, Bazel lock check, and CI.