Migrate fork and resume reads to thread store by wiltzius-openai · Pull Request #18900 · openai/codex

wiltzius-openai · 2026-04-21T22:13:52Z

Route cold thread/resume and thread/fork source loading through ThreadStore reads instead of direct rollout path operations
Keep lookups that explicitly specify a rollout-path using the local thread store methods but return an invalid-request error for remote ThreadStore configurations
Add some additional unit tests for code path coverage

wiltzius-openai · 2026-04-22T21:11:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4684212b00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-23T21:26:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a33177f384

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-23T21:42:10Z

+            .thread_store
+            .read_thread(StoreReadThreadParams {
+                thread_id,
+                include_archived: true,
+                include_history: true,
+            })


Read fork result from the fork-configured store

thread_fork builds a per-request config (with user overrides) and creates the new thread using thread_manager, which selects a store from that config. The follow-up read in read_stored_thread_for_new_fork ignores that and always queries self.thread_store (startup store). If overrides change experimental_thread_store_endpoint, the fork is written to one backend but read from another, causing spurious "not found" failures.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-23T21:42:10Z

+            .read_thread(StoreReadThreadParams {
+                thread_id,
+                include_archived: true,
+                include_history: true,
+            })


Avoid loading full history for excludeTurns forks

read_stored_thread_for_new_fork always requests include_history: true. In thread_fork, this runs even when excludeTurns=true (the intended cheap path), so persistent forks still deserialize the entire rollout history just to build a summary. That adds avoidable latency/memory cost and can make large forks slow or fail under load.

Useful? React with 👍 / 👎.

wiltzius-openai · 2026-04-23T21:46:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22e9b89dde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-23T22:01:59Z

+            self.thread_store
+                .read_thread(StoreReadThreadParams {
+                    thread_id: existing_thread_id,
+                    include_archived: true,
+                    include_history: true,
+                })


Keep fallback path lookup when thread-store read is unavailable

When path is omitted, this now unconditionally uses self.thread_store.read_thread(...). In remote-store mode, RemoteThreadStore::read_thread is currently unimplemented, so thread/fork and thread/resume by thread ID fail with INTERNAL errors instead of working from local rollout files. This is a regression from the prior direct rollout-path lookup behavior.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-23T23:34:57Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-23T23:35:59Z

@codex review

chatgpt-codex-connector · 2026-04-23T23:38:46Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pakrym-oai · 2026-04-24T16:04:33Z

+    if !tokio::fs::try_exists(path).await.unwrap_or(false) {
+        return false;
+    }
+    read_thread_from_rollout_path(store, path.to_path_buf())


surprised we need to double check ids. not sure how we ever get the missalignment

wiltzius-openai changed the base branch from main to wiltzius/codex/thread-store-live-writes April 21, 2026 22:16

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch 2 times, most recently from a1cf2fd to 3304803 Compare April 21, 2026 22:27

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 6ab42ef to 0a97cbd Compare April 22, 2026 21:06

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 3304803 to 4684212 Compare April 22, 2026 21:10

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18900)

1f08dd6

wiltzius-openai marked this pull request as ready for review April 22, 2026 21:53

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18900)

a32c66c

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 1f08dd6 to a32c66c Compare April 22, 2026 22:01

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18900)

344d17d

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from a32c66c to 344d17d Compare April 22, 2026 22:19

wiltzius-openai added a commit that referenced this pull request Apr 22, 2026

codex: address PR review feedback (#18900)

707e1f3

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 344d17d to 707e1f3 Compare April 22, 2026 22:31

wiltzius-openai assigned aibrahim-oai Apr 22, 2026

wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-writes branch from 58068b9 to 070c747 Compare April 23, 2026 16:33

wiltzius-openai requested a review from a team as a code owner April 23, 2026 16:33

Base automatically changed from wiltzius/codex/thread-store-live-writes to main April 23, 2026 17:17

wiltzius-openai added a commit that referenced this pull request Apr 23, 2026

codex: address PR review feedback (#18900)

17882c8

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 707e1f3 to 17882c8 Compare April 23, 2026 17:27

wiltzius-openai added a commit that referenced this pull request Apr 23, 2026

codex: address PR review feedback (#18900)

a33177f

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 17882c8 to a33177f Compare April 23, 2026 21:26

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 23, 2026

codex: address PR review feedback (#18900)

22e9b89

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from a33177f to 22e9b89 Compare April 23, 2026 21:46

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 23, 2026

codex: address PR review feedback (#18900)

acd2e25

wiltzius-openai added a commit that referenced this pull request Apr 23, 2026

codex: address PR review feedback (#18900)

71885e6

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 21610d1 to 71885e6 Compare April 23, 2026 23:52

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

86dfb4b

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 71885e6 to 86dfb4b Compare April 24, 2026 00:03

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

b4e8ff8

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 86dfb4b to b4e8ff8 Compare April 24, 2026 00:09

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

aa5066a

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from b4e8ff8 to aa5066a Compare April 24, 2026 01:29

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

4a63d3d

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from aa5066a to 4a63d3d Compare April 24, 2026 01:39

github-actions Bot mentioned this pull request Apr 24, 2026

📊 AI CLI 工具社区动态日报 2026-04-24 borq168/big_model_radar#1

Open

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

35f560c

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 4a63d3d to 35f560c Compare April 24, 2026 02:16

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

20ce4b4

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 35f560c to 20ce4b4 Compare April 24, 2026 02:47

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

e801d87

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 20ce4b4 to e801d87 Compare April 24, 2026 03:45

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

51786a8

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from e801d87 to 51786a8 Compare April 24, 2026 03:46

wiltzius-openai mentioned this pull request Apr 24, 2026

[codex] Migrate thread turns list to thread store #19280

Open

pakrym-oai reviewed Apr 24, 2026

View reviewed changes

pakrym-oai approved these changes Apr 24, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 24, 2026

codex: address PR review feedback (#18900)

079c897

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 51786a8 to 079c897 Compare April 24, 2026 18:31

wiltzius-openai added 2 commits April 24, 2026 11:31

Migrate fork and resume reads to thread store

ce17dec

codex: address PR review feedback (#18900)

9298207

wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch from 079c897 to 9298207 Compare April 24, 2026 18:39

Conversation

wiltzius-openai commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wiltzius-openai commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

wiltzius-openai commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wiltzius-openai commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 23, 2026

Uh oh!

wiltzius-openai commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 23, 2026

Uh oh!

pakrym-oai Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wiltzius-openai commented Apr 21, 2026 •

edited

Loading